conda-forge / typer-feedstock

A conda-smithy repository for typer.

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

click 8.1.0 breaks typer 0.4.0 #7

Closed swails closed 2 years ago

swails commented 2 years ago

See tiangolo/typer#377 for more information

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

swails commented 2 years ago

this pin is needed to avoid an ImportError on simply importing typer (typer is completely unusable with click 8.1.0)

bollwyvl commented 2 years ago

Thanks for the PR!

Unfortunately, and frustratingly, adding a pin won't necessarily help much, as the solver is "greedy," and will simply select the older, still-incompatible version _0.

In the near term, we just have to deal with pinning versions (in this case, click).

The longer-term hope is for https://github.com/tiangolo/typer/pull/375 which would either preserve functionality with the existing range, or revise the bottom-supported version, and a future version should pass.

If an upstream fix isn't forthcoming soon (a lot of people seem motivated to help), we can revisit this.

bollwyvl commented 2 years ago

8 adds a click 8.1-compatible typer. Thanks again!

tiangolo commented 2 years ago

Hello! I just released Typer 0.4.1 that should handle this. :rocket: :nerd_face:

bollwyvl commented 2 years ago

@tiangolo thanks! we've already got that version up but still waiting for CDN for it to be widely distributed. :blush: