search

conda-forge / ucc-feedstock

A conda-smithy repository for ucc.
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

`ucc` builds did not pick up latest `ucx` (v1.16.0). #7

Closed leofang closed 4 months ago

leofang commented 4 months ago

The assumption in #2 is that we use v1.16.0 build 2 or above. This is currently broken.

leofang commented 4 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in conda-forge/ucc-feedstock#8.

leofang commented 4 months ago

The root cause is we still pin at v1.15.0 globally: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/604816c8db83f9ceefbc4a04ba4de09747cf3822/recipe/conda_build_config.yaml#L857-L858 and it seems the migration bot failed to issue a version update PR to update the pinning (cc: @conda-forge/ucx-split for vis)

jakirkham commented 4 months ago

Please see upstream issue: https://github.com/regro/cf-scripts/issues/2519

jakirkham commented 4 months ago

If it is ok, I would like to use this feedstock as a test case to confirm we have fixed this issue (once we do have it fully fixed)

leofang commented 4 months ago

by all means, thx

jakirkham commented 4 months ago

Bot migrator is in thanks to help from Matt! 🙏

So we should see a migration PR here shortly

xref: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5836

leofang commented 4 months ago

@jakirkham it works now! #10

But it was delayed quite a bit -- I see the migrator was already issued to openmpi (https://github.com/conda-forge/openmpi-feedstock/pull/154) 20 hours ago but not here. I think what happened was that the dependency version migration only works when the feedstock is on the latest version, which was not the case. I had to merge #9 first, and within an hour #10 arrived.

leofang commented 4 months ago

Both UCC versions are rebuilt with against UCX 1.16:

jakirkham commented 4 months ago

@jakirkham it works now! #10

But it was delayed quite a bit -- I see the migrator was already issued to openmpi (conda-forge/openmpi-feedstock#154) 20 hours ago but not here. I think what happened was that the dependency version migration only works when the feedstock is on the latest version, which was not the case. I had to merge #9 first, and within an hour #10 arrived.

Glad to hear that

Feel free to raise an issue with more details if you like

Though it's worth remembering that the bot runs on an infrequently run cron job. Plus we recently added a NumPy 2 migrator to its load (though have recently paused that to work out some kinks)

Personally want to see how things go in future migrations