conda-forge / ucx-split-feedstock

A conda-smithy repository for ucx-split.
BSD 3-Clause "New" or "Revised" License
0 stars 24 forks source link

ucx-split v1.17.0 #182

Closed regro-cf-autotick-bot closed 5 months ago

regro-cf-autotick-bot commented 5 months ago

Close #183.

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
ctng-compilers 14.1.0 Anaconda-Server Badge
rdma-core 52.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 5 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 5 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 4 months ago

Thanks Leo! 🙏 Appreciate your help getting this in (especially in my absence)

Looking at the failure in one CI job( log attached ), it appears this is due to a missing #include upstream ( https://github.com/openucx/ucx/issues/9969 )

Given UCX is used by other packages (like OpenMPI), which can result in it showing up on PPC systems, think we do want to fix this issue. Though understand the pressing need to get the release out. Perhaps in the future we can just merge (ignoring the failing jobs) and write up an issue about the failure for someone to follow up on when they have cycles?

Edit: Filing issue ( https://github.com/conda-forge/ucx-split-feedstock/issues/185 ) to track fixing this

leofang commented 4 months ago

Though understand the pressing need to get the release out. Perhaps in the future we can just merge (ignoring the failing jobs) and write up an issue about the failure for someone to follow up on when they have cycles?

My view is different. The fact that this simple error was not caught upstream is an indication that ppc64le builds were no longer a priority to the UCX team. Today it's a one-liner fix that we can easily and confidently patch. But it may not be the case for any other issues showing up tomorrow (imagine it could be a subtle multithreading bug). I am not willing to let the CI show failures indefinitely. It'd only cause confusion and frustration to other maintainers and casual contributors. I'd rather kill it (but I am OK to create an issue to track it) and let someone who has time and resource to investigate later.

I am also puzzled why it is a big deal to downstream packages. The previous version (v1.16) still works fine.

pentschev commented 4 months ago

I am also puzzled why it is a big deal to downstream packages. The previous version (v1.16) still works fine.

This is unfortunately not always true, older UCX versions do work well for HW that has been out for some time, but newer HW often needs UCX fixes to work appropriately. UCX 1.17 has several fixes that are required to run in the newest clusters and that's why it's important for some teams working on those.

leofang commented 4 months ago

@pentschev note that the context here is ppc support, which is an architecture at its dusk time. I don't mean it's a general principle to skip new version updates at the maintainers' will. Do you know if v1.17 has critical bug fixes for PowerPC?

jakirkham commented 4 months ago

Think with this bug the code was depending on undefined behavior (something else to #include <math.h> to define INFINITY instead of doing that itself). To illustrate this, please see [this example]( https://godbolt.org/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,selection:(endColumn:45,endLineNumber:1,positionColumn:45,positionLineNumber:1,selectionStartColumn:45,selectionStartLineNumber:1,startColumn:45,startLineNumber:1),source:'//+TODO:+Toggle+comment+to+(un)resolve+error%0A//+%23include+%3Cmath.h%3E%0A%0Afloat+get_inf()+%7B%0A++++return+INFINITY%3B%0A%7D'),l:'5',n:'1',o:'C%2B%2B+source+%231',t:'0')),k:33.333333333333336,l:'4',n:'0',o:'',s:0,t:'0'),(g:!((h:compiler,i:(compiler:g141,filters:(b:'0',binary:'1',binaryObject:'0',commentOnly:'0',debugCalls:'1',demangle:'0',directives:'0',execute:'1',intel:'0',libraryCode:'0',trim:'1',verboseDemangling:'0'),flagsViewOpen:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,libs:!(),options:'',overrides:!(),selection:(endColumn:1,endLineNumber:1,positionColumn:1,positionLineNumber:1,selectionStartColumn:1,selectionStartLineNumber:1,startColumn:1,startLineNumber:1),source:1),l:'5',n:'0',o:'+x86-64+gcc+14.1+(Editor+%231)',t:'0')),k:33.333333333333336,l:'4',n:'0',o:'',s:0,t:'0'),(g:!((h:output,i:(compilerName:'x86-64+gcc+14.1',editorid:1,fontScale:14,fontUsePx:'0',j:1,wrap:'1'),l:'5',n:'0',o:'Output+of+x86-64+gcc+14.1+(Compiler+%231)',t:'0')),k:33.33333333333333,l:'4',n:'0',o:'',s:0,t:'0')),l:'2',n:'0',o:'',t:'0')),version:4 )

For whatever reason we just happen to see it on PPC. Unclear on why we don't see the compilation error elsewhere given we are using the same GCC version across Linux architectures