search

conda-forge / ucx-split-feedstock

A conda-smithy repository for ucx-split.
BSD 3-Clause "New" or "Revised" License
0 stars 24 forks source link

[ci skip] adding user @marcinz #188

Closed conda-forge-admin closed 4 months ago

conda-forge-admin commented 4 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've added user @marcinz as instructed in #187.

Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.

Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.

jakirkham commented 4 months ago

@conda-forge-admin , please re-render

leofang commented 4 months ago

@marcinz please kindly confirm you're ok with serving as a maintainer in this feedstock, thanks! 🙂

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 months ago

@conda-forge-admin , please re-render

@jakirkham I thought the adding-user PRs cannot be rerendered? Didn't the PR description mention this?

Please do not rerender this PR or change it in any way.

github-actions[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ucx-split-feedstock/actions/runs/9655334663.

marcinz commented 4 months ago

@marcinz please kindly confirm you're ok with serving as a maintainer in this feedstock, thanks! 🙂

I confirm.

leofang commented 4 months ago

Thanks, Marcin! Once @jakirkham addresses the question (https://github.com/conda-forge/ucx-split-feedstock/pull/188#issuecomment-2187817912) let's merge.

jakirkham commented 4 months ago

I thought the adding-user PRs cannot be rerendered? Didn't the PR description mention this?

Please do not rerender this PR or change it in any way.

That's because they are trying to minimize CI usage when it is unneeded. However CI already started for the first commit anyways

As adding a user ends up changing things in a slightly different way that misses some changes that a re-render would include, like to include the re-render to cutdown on churn related to user additions in unrelated subsequent PRs

jakirkham commented 4 months ago

Thanks Marcin and welcome! 😄

Please follow these instructions to accept membership on this team: https://github.com/conda-forge/ucx-split-feedstock/commit/b60fb426784cbb6d5cbd384a76c86920737838f0#commitcomment-143532388

Thanks Leo for facilitating! 🙏