Remove python constraints

conda-forge / unidist-packages-feedstock

A conda-smithy repository for unidist-packages.

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

Remove python constraints #17

Closed YarShev closed 7 months ago

YarShev commented 7 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

YarShev commented 7 months ago

@h-vetinari, hi, could I get your help here please? Let me explain the problem. Prior to 0.5.0 unidist was built with noarch. There hasn't been any issue with builds. As of 0.5.0 unidist contains some cython extension(s). I forgot to remove the noarch step in #14 and new builds of unidist 0.5.0 were broken since python couldn't find those cython extentions. The error looks like.

ModuleNotFoundError: No module named 'unidist.core.backends.mpi.core._memory'

Then, I removed noarch in #15 and #16 and added some python constraints to not have builds with python 3.12 since Ray doesn't have it. Unfortunately, I got only three builds of unidist 0.5.0 package for python 3.11. In this PR I am trying to eventually get unidist 0.5.0 working. Could you take a look at the meta.yml? What am I missing to make unidist built for different python versions and different platforms.

YarShev commented 7 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/unidist-packages-feedstock/actions/runs/6892220394.

YarShev commented 7 months ago

@conda-forge-admin, please rerender

h-vetinari commented 7 months ago

@h-vetinari, hi, could I get your help here please?

Seems you figured things out? In general, if you want to build per python version, don't specify a lower bound, but leave it as plain - python, like that conda smithy will correctly generate separate jobs

YarShev commented 7 months ago

@h-vetinari, yes, we figured out the root cause. I don't know if it is really an issue with conda or not, but it looks frustrating. Maintainers of other conda-forge feedstocks may see this issue in their feedstock at some point. It would be great to fix the issue or document it somewhere. Thanks for your response, btw.