Closed traversaro closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
@conda-forge-admin, please rerender
It seems that the script is not able to extract some .dll, probably something changed in the sctructure of the redist installer.
This is the manifest of 14.28.29325
(previous version working):
while this is the manifest of 14.29.30037
(new version, not providing api-ms-win-core-***.dll
:
By looking in my system, indeed in the Visual Studio install in C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Redist\MSVC\14.29.30036\x64\Microsoft.VC142.CRT
the only files there are:
STraversaro@IITICUBLAP102 MINGW64 /c/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Redist/MSVC/14.29.30036/x64/Microsoft.VC142.CRT
$ ls
concrt140.dll* msvcp140_2.dll* vccorlib140.dll*
msvcp140.dll* msvcp140_atomic_wait.dll* vcruntime140.dll*
msvcp140_1.dll* msvcp140_codecvt_ids.dll* vcruntime140_1.dll*
api-ms-core-*
are part of UCRT and was shipped with earlier versions of vcredist and it seems that microsoft has dropped them.
This is part of the OS for windows 10, but is not for windows 8. See https://docs.microsoft.com/en-us/cpp/porting/upgrade-your-code-to-the-universal-crt?view=msvc-160#deployment-and-redistribution-of-the-universal-crt
Not sure what to do here. cc @conda-forge/core.
Can we ship them as a separate package for Windows 8 users (if we can get them from somewhere) and just drop them from the default vc
package?
We can get them from windows sdk ISO.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
@conda-forge-admin, rerender
Fixes https://github.com/conda-forge/vc-feedstock/issues/36 .
It is the first time I do this, so it is possible I am doing something wrong. @isuruf do you think it make sense to remove the 16.8 combination from
conda_build_config.yaml
?Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)