Add run_constrained to vs activation

conda-forge / vc-feedstock

A conda-smithy repository for vc.

BSD 3-Clause "New" or "Revised" License

4 stars 22 forks source link

Add run_constrained to vs activation #75

Closed isuruf closed 7 months ago

isuruf commented 7 months ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'vs2015_runtime' output doesn't have any tests.
It looks like the 'vc' output doesn't have any tests.

h-vetinari commented 7 months ago

Seems something changed about how the redistributable exe packages the cab files, at least for x64. We get ERROR: No such file or directory, somewhere in unpack_cab(os.path.join(tmpdir, cabs[0]), cabdir1, env) (if I read the stack trace correctly).

jdblischak commented 7 months ago

What is the status of this PR? The related PR in the pinning feedstock, https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5756, was already merged

github-actions[bot] commented 7 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!