conda-forge / vc-feedstock

A conda-smithy repository for vc.

BSD 3-Clause "New" or "Revised" License

4 stars 22 forks source link

Fix v19.41 support #84

Closed figueroa1395 closed 3 weeks ago

figueroa1395 commented 1 month ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Attempts to fix #83

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

figueroa1395 commented 1 month ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

Package version is missing.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

figueroa1395 commented 1 month ago

@conda-forge-admin, please rerender

figueroa1395 commented 4 weeks ago

@conda-forge-admin, please rerender

figueroa1395 commented 4 weeks ago

@isuruf @h-vetinari Since you are the most active maintainers, could you please give me a hand? I am lost on how to fix this.

isuruf commented 4 weeks ago

What are you trying to fix here?

h-vetinari commented 3 weeks ago

What are you trying to fix here?

83

FWIW, the images still seem to be changing back and forth. In this run, I even got both cases simultaneously. One had

%SRC_DIR%>type "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\\VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt" 
14.40.33807

the other

%SRC_DIR%>type "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\\VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt" 
14.41.34120

figueroa1395 commented 3 weeks ago

@isuruf @h-vetinari Indeed I am attempting to fix #84, but I am not really familiar on how to. It seems to be that Azure's images are not helping much.

TonyXiang8787 commented 3 weeks ago

@figueroa1395 you need to run re-render locally instead of using web commands. The re-render web commands do not work well for this repository.

https://conda-forge.org/docs/maintainer/updating_pkgs/#dev-rerender-local

isuruf commented 3 weeks ago

Please see the discussion on https://github.com/conda-forge/vc-feedstock/pull/82. I'm closing this PR as it seems to just be a waste of time for you without the context.