conda-forge / vega-cli-feedstock

A conda-smithy repository for vega-cli.
BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

Update to 5.17.0 and install via npm #6

Closed jamesmyatt closed 3 years ago

jamesmyatt commented 3 years ago

Checklist

I don't know very much about javascript and npm, but I've taken inspiration from other feedstocks like:

I can't say I'm sure that this is correct, since the test doesn't seem to have worked correctly: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=248384&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=1142

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

jamesmyatt commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.