conda-forge / vigra-feedstock

A conda-smithy repository for vigra.
BSD 3-Clause "New" or "Revised" License
0 stars 14 forks source link

Retry using VS2019 or newer #128

Closed h-vetinari closed 4 months ago

h-vetinari commented 8 months ago

About 1.5 years ago, be57b0f0476f92aae806b93b8ad9b31d5b83d825 went back to VS2017 due to some apparent issues at the time. It would be good to remove https://github.com/conda-forge/vigra-feedstock/blob/5fba74712227c0425deaebe99e601a59fe8f1c76/recipe/conda_build_config.yaml#L1-L5

and just use the conda-forge default compilers, as vigra is among the last feedstocks in conda-forge to still use VS2017.

Hopefully vigra has become compatible with newer VS in the meantime... 🤞

hmaarrfk commented 8 months ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started rerendering the recipe in conda-forge/vigra-feedstock#129.

hmaarrfk commented 8 months ago

It seems we are still having errors with the latest version.

I remember I had tracked it down a bit, but never got to the bottom of it: https://github.com/ukoethe/vigra/issues/525

h-vetinari commented 8 months ago

Thanks for checking!

hmaarrfk commented 8 months ago

this might be a compiler error. the iterator has a const and a non-const version. is there a newer compiler version? 2022??

h-vetinari commented 8 months ago

is there a newer compiler version? 2022??

Yes, vs2022. Should be functional; if not, let us know on the vc-feedstock.

hmaarrfk commented 8 months ago

hmm ok lets try.

h-vetinari commented 4 months ago

Fixed by #131

hmaarrfk commented 4 months ago

but only in the sense that i gave up even more ;)

h-vetinari commented 4 months ago

Also in the sense that there's no more vs2017 components in the Azure images: https://github.com/conda-forge/vc-feedstock/issues/78

hmaarrfk commented 4 months ago

oh.... really lucky that I gave up at the right time!!!