search

conda-forge / vigra-feedstock

A conda-smithy repository for vigra.
BSD 3-Clause "New" or "Revised" License
0 stars 14 forks source link

make sure to use the correct shared lib on win #65

Closed k-dominik closed 3 years ago

k-dominik commented 4 years ago

Checklist

this PR makes sure that one windows the correct version of lemon is included. The first working build will be *_10 once https://github.com/conda-forge/lemon-feedstock/pull/18 is merged!

Not sure about the syntax here, btw, is lemon 1.3.1>=*_10 # [win] correct to include only builds 10 and up on windows?

alternatively, one could of course delete all lemon windows packages up to now (they should not be functioning properly anyway).

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

k-dominik commented 4 years ago

@conda-forge-admin please re-render.

k-dominik commented 4 years ago

@conda-forge-admin please re-render.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

k-dominik commented 3 years ago

hi @conda-forge/vigra I'm pretty sure I didn't get the pinning syntax right, but last time I checked, there weren't many docs on that:

got the following build error:

conda.exceptions.ResolvePackageNotFound: 
  - lemon[version='1.3.1>=*_3']
hmaarrfk commented 3 years ago

@conda-forge-admin please rerender

hmaarrfk commented 3 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

hmaarrfk commented 3 years ago

It seems to have picked up the new build:

    lemon:           1.3.1-h7f30438_3           conda-forge

honestly, for build numbers, you can assume that it will take the largest one unless something else is off with the pinnings.

k-dominik commented 3 years ago

It seems to have picked up the new build:

    lemon:           1.3.1-h7f30438_3           conda-forge

honestly, for build numbers, you can assume that it will take the largest one unless something else is off with the pinnings.

I mean cool that it works, in a sense, but for us it is vital that we can access the functionality in vigra that relies on lemon. But I can also implement a pin on our side I guess.

hmaarrfk commented 3 years ago

I see. You want to pin the run time dependency. Not too sure how

hmaarrfk commented 3 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!