Rebuild python310 + patches

conda-forge / vigra-feedstock

A conda-smithy repository for vigra.

BSD 3-Clause "New" or "Revised" License

0 stars 14 forks source link

Rebuild python310 + patches #84

Closed k-dominik closed 2 years ago

k-dominik commented 2 years ago

trying to see if ci would pass...

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes https://github.com/conda-forge/vigra-feedstock/pull/83

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

k-dominik commented 2 years ago

any idea about fixing the win-py310-npy1.21 build? @hmaarrfk (tagging you because you seem pretty active in here)

k-dominik commented 2 years ago

ah yeah, I'll get a fresh windows build machine ready today and look into it some more

jakirkham commented 2 years ago

Was about to say it does appear to build vigranumpytest.cp310-win_amd64.pyd. Almost wonder if something isn't getting copied over correctly (like a CMakeLists.txt bug)?

hmaarrfk commented 2 years ago

@conda-forge-admin please rerender

hmaarrfk commented 2 years ago

what about trying this patch: https://github.com/ukoethe/vigra/pull/485

k-dominik commented 2 years ago

weird, in the last iteration (before rerender) the python 3.9/numpy119 build worked...

hmaarrfk commented 2 years ago

I think i found the issue. See patch in: https://github.com/conda-forge/vigra-feedstock/pull/85

k-dominik commented 2 years ago

hey @hmaarrfk cool, let's see if this does it then.

Observations from local builds I've done here: for some reason in the case of the failed builds vigranumpycore cannot find vigraimpex.dll - it's in the same place in all builds, so not sure why it fails. When I copy it manually, the tests pass - so I'd suspect it's a testtime only failure, vigraimpex.dll will be copied in the install step

k-dominik commented 2 years ago

closing in favor of #85