conda-forge / vigra-feedstock

A conda-smithy repository for vigra.
BSD 3-Clause "New" or "Revised" License
0 stars 14 forks source link

Rebuild python310 0 1 h8682cc #85

Closed hmaarrfk closed 2 years ago

hmaarrfk commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

k-dominik commented 2 years ago

installing first doesn't help, I tried that already (tests are run from the build env)

I'm gladly proven wrong :) great that it works!

So installation did the trick?! I don't think https://github.com/conda-forge/vigra-feedstock/pull/85/commits/1fb0cc8b4b87414bb065c8114caa2ad69888e029 is necessary (also incomplete, that variable is checked more often in the same way)

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

Ok, i removed the patch and trying again.

I think recent python 3.9 and 3.10 changed how they look for packages. They might not be looking in the current directory or something. Therefore the tests were failing there for windows. that is my hunch.

hmaarrfk commented 2 years ago

shall we merge this?

jakirkham commented 2 years ago

Thanks Mark! 😄