conda-forge / vmtk-feedstock

A conda-smithy repository for vmtk.
BSD 3-Clause "New" or "Revised" License
6 stars 5 forks source link

Rebuild for libboost 1.82 & vtk 9.2.6 #19

Closed regro-cf-autotick-bot closed 10 months ago

regro-cf-autotick-bot commented 11 months ago

This PR has been triggered in an effort to update vtk926.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6396172073, please use this URL for debugging.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 11 months ago

@conda-forge/vmtk The fact that this recipe is pinning to old versions of itk & vtk makes it difficult to move forward -- the rest of the ecosystem has moved on. I made an effort to update it, but -- after getting it to build -- am running into a handful of test errors. It looks like a relatively minor tolerance violation, but what do I know... Help would be appreciated 🙃

=========================== short test summary info ===========================
FAILED tests/test_vmtkscripts/test_importvtkvmtk.py::test_import_vtkvmtk - AssertionError: assert False
 +  where False = hasattr(<module 'vmtk.vtkvmtk' from 'D:\\bld\\vmtk_1696900431874\\_test_env\\lib\\site-packages\\vmtk\\vtkvmtk.py'>, 'vtkvmtkStaticTemporalInterpolatedVelocityField')
FAILED tests/test_vmtkscripts/test_vmtksurfacebooleanoperation.py::test_operations_default_tolerance_regression[intersection-1] - AssertionError: assert False == True
 +  where False = <function compare_surfaces.<locals>.make_compare_surface at 0x000001D11E156700>(<vtkmodules.vtkCommonDataModel.vtkPolyData(0x000001D1212A2F30) at 0x000001D11E45A880>, 'test_vmtksurfacebooleanoperation_test_operations_default_tolerance_1.vtp', tolerance=1e-06)
 +    where <vtkmodules.vtkCommonDataModel.vtkPolyData(0x000001D1212A2F30) at 0x000001D11E45A880> = <vmtk.vmtksurfacebooleanoperation.vmtkSurfaceBooleanOperation object at 0x000001D11E448A00>.Surface
FAILED tests/test_vmtkscripts/test_vmtksurfacebooleanoperation.py::test_operations_default_tolerance_regression[difference-2] - AssertionError: assert False == True
 +  where False = <function compare_surfaces.<locals>.make_compare_surface at 0x000001D11E156700>(<vtkmodules.vtkCommonDataModel.vtkPolyData(0x000001D11D7B42D0) at 0x000001D11E45AC40>, 'test_vmtksurfacebooleanoperation_test_operations_default_tolerance_2.vtp', tolerance=1e-06)
 +    where <vtkmodules.vtkCommonDataModel.vtkPolyData(0x000001D11D7B42D0) at 0x000001D11E45AC40> = <vmtk.vmtksurfacebooleanoperation.vmtkSurfaceBooleanOperation object at 0x000001D11E46BC40>.Surface
====== 3 failed, 690 passed, 26 skipped, 1 xfailed in 149.45s (0:02:29) =======

Two of those tests have a decorator

@pytest.mark.skipif(vtk.vtkVersion.GetVTKVersion() == '9.1.0', reason="requires vtk version != 9.1.0")

which might need to be extended?

ramtingh commented 11 months ago

@h-vetinari Thanks for all the help! The test failures seem minor. I'll have a look over the weekend, I think the upstream vmtk repository has also had some bugfixes I should add

h-vetinari commented 10 months ago

This should ideally have been fixed/merged before #20, which was strictly an additional feature and not necessary to keep the lights on here (as opposed to keeping up with the migrations). In any case, I rebased the PR.

Somewhat surprising to find this now failing with a boost version mismatch; I guess vtk encodes an expectation of the exact version somehow (which isn't great; but OK, we can pull in #21 as well):

Found utf8cpp: $PREFIX/include  
CMake Error at $BUILD_PREFIX/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost: Found unsuitable version "1.78.0", but required is
  exact version "1.82.0" (found
  $PREFIX/include,
  )
Call Stack (most recent call first):
  $BUILD_PREFIX/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE)
  $BUILD_PREFIX/share/cmake-3.27/Modules/FindBoost.cmake:2392 (find_package_handle_standard_args)
  $PREFIX/lib/cmake/vtk-9.2/VTK-vtk-module-find-packages.cmake:491 (find_package)
  $PREFIX/lib/cmake/vtk-9.2/vtk-config.cmake:152 (include)
  CMakeLists.txt:78 (find_package)
h-vetinari commented 10 months ago

OK, this builds now, but we're back to the same failures that we had above. Would appreciate if you could take a look @ramtingh :)

ramtingh commented 10 months ago

@conda-forge-admin, please rerender

ramtingh commented 10 months ago

@conda-forge-admin, please restart ci

ramtingh commented 10 months ago

@h-vetinari I think everything is sorted out now. Thanks!