conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

win: lz4 lib path not replaced correctly (win-64/vtk-8.2.0-py38hb4a5736_210) #106

Closed looooo closed 4 years ago

looooo commented 4 years ago

https://forum.freecadweb.org/viewtopic.php?f=4&t=44379

There are a lot of not replaced paths. Is there something wrong with the new conda-build version (3.19.1) https://github.com/conda/conda-build/issues/3909

xylar commented 4 years ago

@looooo, I've opened #107 to try to deal with this. At first, though this might be related to:

   -DLZ4_LIBRARIES:PATH="%LIBRARY_LIB%\liblz4.lib" ^

but it sounds like that's not the issue and we'd better keep an eye on conda/conda-build#3909

xylar commented 4 years ago

Might be worth asking about this on gitter if you haven't already since this affects more than just VTK.

looooo commented 4 years ago

@conda-forge-admin, please rerender

should be fixed by: https://github.com/conda-forge/ripgrep-feedstock/pull/12

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I rerendered the recipe in conda-forge/vtk-feedstock#116.

xylar commented 4 years ago

@looooo, in an hour or so when the package is available, could you verify that you are able to install the latest build and that it fixes this issue? If so, can you close?

looooo commented 4 years ago

Sry, I can't see a new build. Is the ci running?

xylar commented 4 years ago

Yes, CI is running and even then, it takes about 1/2 hour by the time it's done for the new build get found by conda create.

xylar commented 4 years ago

Hmm, I now see that CI didn't run on the merge commit for some reason! I'm going to force it.

xylar commented 4 years ago

Okay, got it going. I'll let you know when you should check on it...

xylar commented 4 years ago

Okay, the package should be ready to test now.

looooo commented 4 years ago

and error is gone. Thanks @xylar