DEV: Use system libraries instead of VTK vendored ones

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

DEV: Use system libraries instead of VTK vendored ones #108

Closed xylar closed 4 years ago

xylar commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 4 years ago

@conda-forge-admin, please rerender

xylar commented 4 years ago

@conda-forge-admin, please rerender

xylar commented 4 years ago

Note: this should not have been a problem with the Windows build (which had relatively little modification from v8.2.0), just the Linux and OSX builds.

xylar commented 4 years ago

@muryanto1, we seem to be good. I'm going to set this to auto-merge once it's done.

xylar commented 4 years ago

Oops, this didn't fix the problem at all:

CMake Warning:
  Manually-specified variables were not used by the project:

    Python2_FIND_STRATEGY
    Python2_ROOT_DIR
    VTK_USE_SYSTEM_EXPAT
    VTK_USE_SYSTEM_FREETYPE
    VTK_USE_SYSTEM_HDF5
    VTK_USE_SYSTEM_JPEG
    VTK_USE_SYSTEM_JSONCPP
    VTK_USE_SYSTEM_LIBXML2
    VTK_USE_SYSTEM_LZ4
    VTK_USE_SYSTEM_NETCDF
    VTK_USE_SYSTEM_PNG
    VTK_USE_SYSTEM_TIFF
    VTK_USE_SYSTEM_ZLIB

:-(