vtk v9.0.0

[regro-cf-autotick-bot]

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

1. Feel free to push to the bot's branch to update this PR if needed.
2. The bot will almost always only open one PR per version. Checklist before merging this PR:
   • [x] Dependencies have been updated if changed: see upstream
   • [x] Tests have passed
   • [x] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/16425, please use this URL for debugging}

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
boost-cpp	1.73.0
tbb	2020.2

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[xylar]

@conda-forge-admin, please rerender

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

[xylar]

@conda-forge-admin, please rerender

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[xylar]

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in https://github.com/conda-forge/vtk-feedstock/pull/105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

[xylar]

It looks like the release hasn't gone live yet at https://vtk.org/download/ and the hash is getting changed. I guess we'd better hold off on merging, but @jsbronder, it still would make sense to try to figure out TCL/TK.

[xylar]

@conda-forge/vtk, even though the release isn't posted yet on the VTK download page, it would be very good to get a review from as many of you as possible. Given that the release has already been tagged on the GitLab web page, I don't expect any remaining changes to affect the recipe other than the sha256.

[looooo]

it would be nice to try to avoid "build_env" prefixed paths in the cmake files. We saw some problems with this in vtk8.2: https://github.com/conda-forge/vtk-feedstock/issues/86

[xylar]

@looooo, please edit the recipe and let's see how it goes.

[looooo]

I didn't find any "buid_env" prefixes in the cmake files of the vtk9.0.0.rc3 package. So I guess this is not a problem.

[jsbronder]

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in #105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

Will do, I'll take a look early next week.

[jsbronder]

@jsbronder, I believe your help is needed to get TCL/TK support working in 9.0.0. As we discussed in #105, I don't think I was successful in getting it to work and eventually had to move on with 9.0.0rc1 without it. Perhaps 9.0.0 will be easier?

Will do, I'll take a look early next week.

This all seems to work for me. I cloned vtk-feedstock and used the following script:

#!/usr/bin/env bash

topdir=$(dirname $(realpath -m $0))

export BUILD_CONFIG=Release
export PREFIX=${topdir}
export PY_VER=3
export SP_DIR=lib/python${PY_VER}/sites-packages

bash /home/jbronder/st/vtk-feedstock/recipe/build.sh

Once that completes I can:

PYTHONPATH=lib/python3.7/site-packages/ python -c 'import vtk.tk.vtkTkRenderWidget'

which all works. What exactly are you seeing fail?

[xylar]

@jsbronder, if it seems to be working, that's great! I had commented just before merging this PR to dev that I was disabling TK support: https://github.com/conda-forge/vtk-feedstock/pull/105#issuecomment-601730063 And since I am more or less bringing over that recipe, I thought that was still going to be the case here. I haven't had time to investigate further and am not able to do a non-osmesa build on my local machine so I haven't done any of my own testing.

[jschueller]

also please include the change from #130 else wrong headers are found

[xylar]

I'll do that, too.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[xylar]

@conda-forge-admin, please rerender

[xylar]

-- Could NOT find LibHaru: Found unsuitable version "2.3.0-RC2", but required is at least "2.4.0" (found $PREFIX/lib/libhpdf.so)
-- Configuring incomplete, errors occurred!

This message seems strange for two reasons:

1. The current release of libharu is 2.3.0: http://libharu.org/
2. The there is a build of that release and it should be available, so I don't know how it's finding 2.3.0-RC2 instead

[xylar]

So the answer to the second question is that the header file for the 2.3.0 release of libharu still says it's RC2: https://github.com/libharu/libharu/blob/RELEASE_2_3_0/include/hpdf_version.h#L6-L7

[xylar]

Okay, and here's the answer to the first question: https://gitlab.kitware.com/vtk/vtk/-/blob/master/ThirdParty/libharu/CMakeLists.txt#L8-10 VTK requires an unreleased version.

[xylar]

@conda-forge-admin, please rerender

[xylar]

@conda-forge-admin, please rerender

[MuellerSeb]

Okay, and here's the answer to the first question: https://gitlab.kitware.com/vtk/vtk/-/blob/master/ThirdParty/libharu/CMakeLists.txt#L8-10 VTK requires an unreleased version.

Seems like LibHaru needs a new maintainer (as written on their webpage)

[xylar]

Given that builds without mesalib are building correctly and I don't know what the problem is with the mesalib build, I'm going to disable the mesalib builds for now to get this merged.

[xylar]

@conda-forge-admin, please rerender

[jschueller]

bld.bat does not actually use external dependencies, the variables are misnamed, see build.sh:

-DVTK_USE_EXTERNAL:BOOL=ON \
    -DVTK_MODULE_USE_EXTERNAL_VTK_libharu:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_diy2:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_kzfp:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_pegtl:BOOL=OFF \
    -DVTK_MODULE_USE_EXTERNAL_VTK_kissfft:BOOL=OFF \

by the way diy2, kzf and kissfft cannot be enabled via external use, so these are actually also useless from build.sh

[xylar]

Thanks for your ongoing advice, @jschueller. Does my last commit address your last comment?

I think I had meant to update bld.bat earlier once I was sure we had build.sh figured out but forgot. VTK isn't my highest priority, just trying to help out some colleagues who use it...

[jschueller]

perfect, for lzma I had to specify the path to the lib, see pv feedstock

[xylar]

Thanks, that's a very helpful tip!