Closed regro-cf-autotick-bot closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please restart ci
@mbargull: It looks like the linux build is now working. There is still an issue with Tcl/Tk on OS X where it is using some headers from $PREFIX/include, but then system Tcl/Tk libraries from outside the conda environment. See the following excerpts from the build log.
Perhaps we can update the CMAKE command to help VTK find the expected versions.
2020-10-21T20:41:50.4079870Z -- Found Tclsh: $PREFIX/bin/tclsh (found version "8.6")
2020-10-21T20:41:50.4248860Z -- Found TCL: /Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/lib/libtcl.dylib
2020-10-21T20:41:50.4254840Z -- Found TCLTK: /Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/lib/libtcl.dylib
2020-10-21T20:41:50.4259780Z -- Found TK: /Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/lib/libtk.dylib
2020-10-21T20:41:59.3554910Z // Path to a file.
2020-10-21T20:41:59.3555460Z TCL_INCLUDE_PATH:PATH=/Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Tcl.framework/Headers
2020-10-21T20:41:59.3555990Z
2020-10-21T20:41:59.3556210Z // Path to a library.
2020-10-21T20:41:59.3556880Z TCL_LIBRARY:FILEPATH=/Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/lib/libtcl.dylib
2020-10-21T20:41:59.3557370Z
2020-10-21T20:41:59.3557590Z // Path to a program.
2020-10-21T20:41:59.3557920Z TCL_TCLSH:FILEPATH=$PREFIX/bin/tclsh
2020-10-21T20:41:59.3558170Z
2020-10-21T20:41:59.3565810Z
2020-10-21T20:41:59.3566070Z // Path to a file.
2020-10-21T20:41:59.3566640Z TK_INCLUDE_PATH:PATH=/Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Tk.framework/Headers
2020-10-21T20:41:59.3567150Z
2020-10-21T20:41:59.3567430Z // The path to the Tk internal headers (tkMacOSXInt.h).
2020-10-21T20:41:59.3567840Z TK_INTERNAL_PATH:PATH=$PREFIX/include
2020-10-21T20:41:59.3568100Z
2020-10-21T20:41:59.3568360Z // Path to a library.
2020-10-21T20:41:59.3568950Z TK_LIBRARY:FILEPATH=/Applications/Xcode_11.7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/usr/lib/libtk.dylib
2020-10-21T21:05:59.3828040Z In file included from ../Rendering/Tk/vtkCocoaTkUtilities.mm:23:
2020-10-21T21:05:59.3829040Z In file included from $PREFIX/include/tkMacOSXInt.h:18:
2020-10-21T21:05:59.3831310Z In file included from $PREFIX/include/tkInt.h:19:
2020-10-21T21:05:59.3832100Z In file included from $PREFIX/include/tkPort.h:21:
2020-10-21T21:05:59.3832860Z $PREFIX/include/tk.h:21:3: error: Tk 8.6 must be compiled with tcl.h from Tcl 8.6 or better
2020-10-21T21:05:59.3833690Z # error Tk 8.6 must be compiled with tcl.h from Tcl 8.6 or better
2020-10-21T21:05:59.3834310Z ^
2020-10-21T21:05:59.3834770Z 1 error generated.
2020-10-21T21:05:59.3835240Z ninja: build stopped: subcommand failed.
I will try adding
-DTCL_INCLUDE_PATH=${PREFIX}/include
-DTK_INCLUDE_PATH=${PREFIX}/include
to build.sh and see if that works unless there are other suggestions
I had to explicitly provide the path to the conda-installed libtk
/libtcl
as in da481b6 for the OS X build to succeed. It all looks good now, so I will merge.
This PR has been triggered in an effort to update python39.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by , please use this URL for debugging