search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Fix segfault during Mayavi installation #15

Closed dfroger closed 7 years ago

dfroger commented 7 years ago

Fixes #13

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

grlee77 commented 7 years ago

LGTM assuming the CI passes. Thanks for getting to the bottom of this!

dfroger commented 7 years ago

It does no find the patch, will look at it tomorrow

Cadair commented 7 years ago

Has there been any progress on this? It looks as though VTK 7.1.1 is not very far away which would fix it upstream?

Korijn commented 7 years ago

I think you answered your own question

Cadair commented 7 years ago

haha, I suppose my question was, is this PR likely to get merged before 7.1.1 is released?

Korijn commented 7 years ago

Hmm... for some reason CI status doesn't include travis and circle... would be good to know that they also pass before we merge this.

@dfroger can you do a little bump commit to trigger CI again?

dfroger commented 7 years ago

closing and reopening the PR shoud trigger CI again

dfroger commented 7 years ago

We don't have travis, but that's ok, as the build is skipped on osx.

dfroger commented 7 years ago

appveyor build was not started, I clicked "re-build pr" in appveyor UI some minites ago. PY=2.7 builds are currently running, PY=3.4 and PY=3.5 are queued.

dfroger commented 7 years ago

PY=3.4 is building. Everything should be green soon...

Korijn commented 7 years ago

LGTM!

dfroger commented 7 years ago

Seems that build number should be 2 instead of 1?

dfroger commented 7 years ago

In the meantime, another merged PR did increase the build number to 1. So this PR didn't actually increase the bulid number (as it increase the old build number from 0 to 1...). I see it too late...

Korijn commented 7 years ago

open a new one?