re-enable Xdmf2 and Xdmf3 support

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

re-enable Xdmf2 and Xdmf3 support #152

Closed grlee77 closed 3 years ago

grlee77 commented 3 years ago

As requested in #66, try adding Xdmf support back to the recipe.

These modules were previously enabled in the VTK 8.2 recipe, but were disabled during the transition from VTK 8.2 to VTK 9.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Maxyme commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthiasdiener commented 3 years ago

This is ready for review @conda-forge/vtk . Unfortunately, tk 8.6.11 does not work correctly on MacOS, so had to limit the tk version for MacOS.

matthiasdiener commented 3 years ago

Also pinging @conda-forge/core for review, in particular regarding whether

    - tk  # [not win and not VTK_WITH_OSMESA and not osx]
    - tk <8.6.11  # [osx and not VTK_WITH_OSMESA]

is the right way to restrict the tk version on MacOS.

matthiasdiener commented 3 years ago

@conda-forge-admin rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

matthiasdiener commented 3 years ago

Closes #66.