Enable VTK_GUISupportQt and VTK_RenderingSupportQt

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

Enable VTK_GUISupportQt and VTK_RenderingSupportQt #172

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

@conda-forge/vtk - this PR is ready to be merged. It adds compilation of the VTK_GUISupportQt and VTK_RenderingSupportQt libraries, which are needed in some downstream packages. For example, some ROS packages require this; as found within the RoboStack project. All platforms but ppc64le are enabled; there is no QT build for PPC as of yet.

/cc @wolfv

Tobias-Fischer commented 3 years ago

@conda-forge/vtk - a quick reminder that it would be great if you could review / merge this PR. Many thanks!

Tobias-Fischer commented 3 years ago

Another ping @conda-forge/vtk

grlee77 commented 3 years ago

This looks good to me. Not sure if there will be any complaints about adding Qt since it is a fairly large package, but I don't have a problem with it.

Does the patch added in 14cab99 correspond to an upstream PR?

Tobias-Fischer commented 3 years ago

Hi @grlee77 - thanks for your feedback! Yes, https://github.com/conda-forge/vtk-feedstock/commit/14cab9918508dc40d0743479fef1bacab2f7a65f correspond to an upstream PR; I added the patch information in https://github.com/conda-forge/vtk-feedstock/pull/172/commits/b43132efd1be0efbae11944d306765cb4113760b

Tobias-Fischer commented 3 years ago

That all seems to work fine now @grlee77 :)

grlee77 commented 3 years ago

Thanks @Tobias-Fischer !

Tobias-Fischer commented 3 years ago

Ah gosh. Just realized that the build number wasn't bumped - as it was bumped in the osx-arm64 migration as well there was no merge conflict. Not sure what the best way is to deal with this?!?

grlee77 commented 3 years ago

Yeah that will probably cause the packages to not get uploaded. The easiest fix is probably just a new PR that only bumps the build number

Tobias-Fischer commented 3 years ago

It did upload them: https://anaconda.org/conda-forge/vtk/files

Now there are multiple builds with the same build_num .. Sorry for that :(. Bump the build number anyhow?