add osx_arm64 support - Githubissues

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

add osx_arm64 support #173

Closed matthiasdiener closed 3 years ago

matthiasdiener commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 3 years ago

If you add this package (or gmsh) to the list of packages in conda-forge-pinning-feedstock, then the bot will send PRs in correct order.

matthiasdiener commented 3 years ago

If you add this package (or gmsh) to the list of packages in conda-forge-pinning-feedstock, then the bot will send PRs in correct order.

Where would I have to add the package? I added gmsh there some time ago (https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/1391).

isuruf commented 3 years ago

That's for linux-arm and power. For osx-arm, https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/osx_arm64.txt

matthiasdiener commented 3 years ago

That's for linux-arm and power. For osx-arm, https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/osx_arm64.txt

I see, thanks! As a side note, these automatic PRs do have the disadvantage that I can not modify them directly, right (since I'm not a package maintainer)? Many PRs will likely need manual attention due to the cross-compilation.

isuruf commented 3 years ago

True. You'll have to send a PR using the commits from the bot PR.

matthiasdiener commented 3 years ago

@conda-forge-admin restart CI

isuruf commented 3 years ago

There's still a few dependencies needed for vtk as seen here, https://raw.githubusercontent.com/regro/cf-graph-countyfair/master/status/armosxaddition.svg?sanitize=true

isuruf commented 3 years ago

@matthiasdiener, the bot will send another PR to update libnetcdf to 4.8.0 and after merging that this PR has to be rebased on top of that.

matthiasdiener commented 3 years ago

@matthiasdiener, the bot will send another PR to update libnetcdf to 4.8.0 and after merging that this PR has to be rebased on top of that.

I see. My intention was to check whether fixing the libnetcdf version gets the build farther.

isuruf commented 3 years ago

Sure. That's fine. Thanks for doing that.

isuruf commented 3 years ago

@matthiasdiener, this is ready.

matthiasdiener commented 3 years ago

@matthiasdiener, this is ready.

LGTM, thanks!