search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

update build number #19

Closed dfroger closed 7 years ago

dfroger commented 7 years ago

Both PR #15 and #12 have increased build number from 0 to 1.

PR #15 should have increase build number from 1 to 2 instead.

I don't know how much it's a problem that PR #15 has wrong build number. Maybe binaries on anaconda.org will overwrite those from PR #12, and user having already installed binaries with build number 1 will not be able to update to the new binaries including PR #15 (as the build number is the same, the package will be considered up to date)?

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Korijn commented 7 years ago

Also add yourself to the recipe maintainers, while you're at it ;)

dfroger commented 7 years ago

Ok, seems I'm already in the recipes maintainers, I'll check.

Or maybe the binaries on anaconda.org are not rebuild until build number is increased?

jakirkham commented 7 years ago

FYI there is no overwriting of existing packages.

dfroger commented 7 years ago

I've rebased on master.

@jakirkham ok, I think so actually. So there is no problem.

dfroger commented 7 years ago

ready for the merge!

ivoflipse commented 7 years ago

LGTM