Remove ParaView constraint

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

Remove ParaView constraint #205

Closed basnijholt closed 2 years ago

basnijholt commented 2 years ago

Reverting https://github.com/conda-forge/vtk-feedstock/pull/84. Here https://github.com/conda-forge/paraview-feedstock/issues/27#issuecomment-492500135 @grlee77 mentions that the problem occurred because ParaView was built with the old compilers.

At the moment ParaView is up-to-date and compiled with the latest compilers.

Having this constraint prevents people from installing FreeCAD (which depends on VTK) and ParaView in the same environment.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

basnijholt commented 2 years ago

@conda-forge-admin, please rerender

jakirkham commented 2 years ago

Should the old paraview packages be marked broken then? Otherwise it seems there would be a risk of constructing a broken environment with this change

basnijholt commented 2 years ago

I have no preference with respect to labeling as broken.

Would that block merging this PR?

jakirkham commented 2 years ago

Just thinking through the implications of this change and next steps

basnijholt commented 2 years ago

@msarahan, @ccordoba12, @grlee77, @jasonb5, or @matthiasdiener, could you please merge this? 😄

grlee77 commented 2 years ago

It looks like Paraview still builds its own VTK rather than relying on this recipe. Are you sure this does not result in any overlapping filenames?

I guess we can always revert this PR if it does end up causing any issues.

jakirkham commented 2 years ago

Hmm...yeah that seems to be the case

In particular still see the paraview recipe carrying a VTK patch. That wouldn't be need there if it was using this vtk package right?

jakirkham commented 2 years ago

cc @jschueller (for awareness)

jschueller commented 2 years ago

these will probably still stay incompatible as they separate the releases, which is understandable from a resource point of view

basnijholt commented 2 years ago

I have locally removed the constrained and installed VTK + ParaView, and indeed it doesn't work. I will close this.