search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

pcl_find_vtk.cmake contains invalid cmake #206

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

As reported by @traversaro in https://github.com/conda-forge/pcl-feedstock/pull/38#issuecomment-939813188 (in the downstream update to vtk 9.0.3), we noticed that the pcl_find_vtk.cmake contains this:

  find_package(FFMPEG
    9c33b2f

    ${_vtk_module_find_package_quiet}
    ${_vtk_module_find_package_required}
    COMPONENTS          avformat;avcodec;avutil;swscale
    OPTIONAL_COMPONENTS )

So there is a hash in there which should not be there.

Any clue on how to approach this? @traversaro @conda-forge/vtk?

lhofmann commented 3 years ago

FYI, the issue is in the file lib/cmake/vtk-9.0/VTK-vtk-module-find-packages.cmake that belongs to the VTK package, not specific to pcl. I'm observing the same problem at https://github.com/conda-forge/topologytoolkit-feedstock and am currently downgrading to VTK 9.0.1 as a temporary workaround.

It looks like the rebuild of vtk proposed in https://github.com/conda-forge/vtk-feedstock/pull/209 might solve this issue.

matthiasdiener commented 3 years ago

Fixed by #209.