9.1.0 h39d90e - Githubissues

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

9.1.0 h39d90e #221

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 2 years ago

I think this is ready to go @conda-forge/vtk. Please double-check the addition of DVTK_REQUIRE_LARGE_FILE_SUPPORT_EXITCODE - I think it should be set to 0 but I'm not 100% sure.

grlee77 commented 2 years ago

Thanks for getting this working!

DVTK_REQUIRE_LARGE_FILE_SUPPORT_EXITCODE - I think it should be set to 0 but I'm not 100% sure.

don't know the answer to this. will leave it open for a bit to see if there is other feedback...

Tobias-Fischer commented 2 years ago

@traversaro - can you provide any insights? You're my cmake go-to person :)

traversaro commented 2 years ago

@traversaro - can you provide any insights? You're my cmake go-to person :)

I looked for references to the VTK_REQUIRE_LARGE_FILE_SUPPORT_EXITCODE CMake option in VTK's code and documentation, but I could not find anything. Do you have any reference?

Tobias-Fischer commented 2 years ago

No .. it showed up in the build log, but no other references ..

traversaro commented 2 years ago

For some reason I can't access past Windows build log with error, sorry about that: not_expected_error

Tobias-Fischer commented 2 years ago

It basically said sth like "Cannot execute bla bla, when cross compiling you need to set DVTK_REQUIRE_LARGE_FILE_SUPPORT_EXITCODE manually".

traversaro commented 2 years ago

It basically said sth like "Cannot execute bla bla, when cross compiling you need to set DVTK_REQUIRE_LARGE_FILE_SUPPORT_EXITCODE manually".

Ah! This sounds like a call to try_run. I will check for it.

Tobias-Fischer commented 2 years ago

Yes that must be it!

traversaro commented 2 years ago

Related code:

Tobias-Fischer commented 2 years ago

So it seems like this is checking for support for 64 bit filesystems, which have been around for quite some time now. Returning 0 is correct in that case. So I think all good!

traversaro commented 2 years ago

So it seems like this is checking for support for 64 bit filesystems, which have been around for quite some time now. Returning 0 is correct in that case. So I think all good!

Yes, it seems correct indeed!

Tobias-Fischer commented 2 years ago

/cc @grlee77 @conda-forge/vtk