conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Re-enable OSMesa builds and add EGL build variant #225

Closed basnijholt closed 2 years ago

basnijholt commented 2 years ago

Checklist

This closes the issue https://github.com/conda-forge/vtk-feedstock/issues/223, and superseded https://github.com/conda-forge/vtk-feedstock/pull/153 and https://github.com/conda-forge/vtk-feedstock/pull/224.

I have locally built the

We're not using the external version of GLEW for EGL/OSMesa, because GLEW needs to be compiled with EGL/OSMesa.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

basnijholt commented 2 years ago

@msarahan, @ccordoba12, @grlee77, @jasonb5, or @matthiasdiener, could you please merge/review this? 😄

All CI builds are passing (with the exception of one of the Windows build timing out for unrelated reasons.)

basnijholt commented 2 years ago

@matthiasdiener, thanks!

Do we need to wait for more reviews before merging?

I am kind of blocked by not having this, so my apologies for being impatient 😄

basnijholt commented 2 years ago

@conda-forge-admin, please restart ci

Just such that all CI builds will have a green checkmark. All builds do already work!

matthiasdiener commented 2 years ago

@matthiasdiener, thanks!

Do we need to wait for more reviews before merging?

I don't know. I was wondering/hoping that someone else from @conda-forge/vtk could also take a look.

matthiasdiener commented 2 years ago

By the way, would you like to add yourself as a maintainer @basnijholt ?

basnijholt commented 2 years ago

@matthiasdiener, sure! I have just done that.

matthiasdiener commented 2 years ago

@conda-forge-admin rerender

basnijholt commented 2 years ago

Everything is passing! ☑ :tada:

grlee77 commented 2 years ago

Okay, let's try it out. Thanks, @basnijholt!