conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Create 9.0.1 with EGL and OSMesa on branch #227

Closed basnijholt closed 2 years ago

basnijholt commented 2 years ago

Checklist

I have put a lot of work into getting VTK with EGL and VTK in https://github.com/conda-forge/vtk-feedstock/pull/225.

Unfortunately, I need to be able to simultaneously install FreeCAD and VTK with EGL but because FreeCAD is only built with VTK 9.0.1 and conflicts prevent me from updating FreeCAD to support 9.1.0, see https://conda-forge.org/status/#other_migrations.

This is because SMESH does not support OCCT 7.6 and OCCT 7.5 is only built with VTK 9.0.1.

Therefore, I have created a branch 9.0.1 from master where this PR will be merged into.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

basnijholt commented 2 years ago

@matthiasdiener any objections?

matthiasdiener commented 2 years ago

@matthiasdiener any objections?

No objections from me (although I'm not familiar with this way of building an older version of a package).

basnijholt commented 2 years ago

This is the way to maintain older versions https://conda-forge.org/docs/maintainer/updating_pkgs.html?highlight=branch#maintaining-several-versions

Otherwise, it's nothing special.

Think we can merge this?

matthiasdiener commented 2 years ago

https://conda-forge.org/docs/maintainer/updating_pkgs.html?highlight=branch#maintaining-several-versions

I see, thanks. I guess it's fine to merge this.

Tobias-Fischer commented 2 years ago

@basnijholt - do you want to add that branch to the ABI migration branches?

basnijholt commented 2 years ago

That might be nice but I'm AFK until February.