conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Update to freetype 2.7 #23

Closed looooo closed 7 years ago

looooo commented 7 years ago

this is necessary because the latest qt package has updated to freetype2.7 too. see https://github.com/conda-forge/vtk-feedstock/issues/22

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Korijn commented 7 years ago

Please note conda-forge has a global pinning policy for these common dependencies. @jakirkham

dfroger commented 7 years ago

The build fails on Windows for Python 3.4 with the error bellow.

Maybe the feedstock needs to be re-render before, to drop Python 3.4 and build for Python 3.6 instead?

FAILED: bin/vtkIOImage-7.1.dll lib/vtkIOImage-7.1.lib 
cmd.exe /C "cd . && C:\bld\recipe_1486445281199\_b_env\Library\bin\cmake.exe -E vs_link_dll --intdir=IO\Image\CMakeFiles\vtkIOImage.dir --manifests  -- C:\PROGRA~2\MICROS~2.0\VC\bin\amd64\link.exe /nologo IO\Image\CMakeFiles\vtkIOImage.dir\vtkBMPReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkBMPWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkDEMReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkDICOMImageReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkGESignaReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageExport.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageImport.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageImportExecutive.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageReader2.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageReader2Collection.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageReader2Factory.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkImageWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkJPEGReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkJPEGWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkJSONImageWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkMedicalImageProperties.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkMedicalImageReader2.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkMetaImageReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkMetaImageWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkNIFTIImageHeader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkNIFTIImageReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkNIFTIImageWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkNrrdReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkPNGReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkPNGWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkPNMReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkPNMWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkPostScriptWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkSLCReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkTIFFReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkTIFFWriter.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkVolume16Reader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkVolumeReader.cxx.obj IO\Image\CMakeFiles\vtkIOImage.dir\vtkMRCReader.cxx.obj  /out:bin\vtkIOImage-7.1.dll /implib:lib\vtkIOImage-7.1.lib /pdb:bin\vtkIOImage-7.1.pdb /dll /version:1.0 /machine:x64  /INCREMENTAL:NO  lib\vtkCommonExecutionModel-7.1.lib lib\vtkCommonDataModel-7.1.lib lib\vtkCommonMisc-7.1.lib lib\vtkCommonSystem-7.1.lib lib\vtkCommonTransforms-7.1.lib lib\vtkDICOMParser-7.1.lib lib\vtkmetaio-7.1.lib C:\bld\recipe_1486445281199\_b_env\Library\lib\jpeg.lib C:\bld\recipe_1486445281199\_b_env\Library\lib\libpng.lib C:\bld\recipe_1486445281199\_b_env\Library\lib\z.lib lib\vtksys-7.1.lib C:\bld\recipe_1486445281199\_b_env\Library\lib\tiff.lib C:\bld\recipe_1486445281199\_b_env\Library\lib\z.lib lib\vtkCommonMath-7.1.lib lib\vtkCommonCore-7.1.lib ws2_32.lib Psapi.lib comctl32.lib wsock32.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib  && cd ."
tiff.lib(libjpeg.dll) : error LNK2005: sscanf already defined in jpeg.lib(jmemmgr.c.obj)
tiff.lib(libjpeg.dll) : error LNK2005: sprintf already defined in jpeg.lib(jerror.c.obj)
tiff.lib(libjpeg.dll) : error LNK2005: fprintf already defined in jpeg.lib(jerror.c.obj)
   Creating library lib\vtkIOImage-7.1.lib and object lib\vtkIOImage-7.1.exp
jpeg.lib(jerror.c.obj) : error LNK2019: unresolved external symbol __imp___acrt_iob_func referenced in function output_message
tiff.lib(tif_unix.obj) : error LNK2001: unresolved external symbol __imp___acrt_iob_func
tiff.lib(tif_ojpeg.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
tiff.lib(tif_jpeg.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
tiff.lib(tif_predict.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
jpeg.lib(jerror.c.obj) : error LNK2019: unresolved external symbol __imp___stdio_common_vfprintf referenced in function _vfprintf_l
tiff.lib(tif_unix.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
tiff.lib(tif_dirinfo.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
tiff.lib(tif_fax3.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vfprintf
jpeg.lib(jerror.c.obj) : error LNK2019: unresolved external symbol __imp___stdio_common_vsprintf referenced in function _vsnprintf_l
tiff.lib(tif_getimage.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vsprintf
tiff.lib(tif_dirinfo.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vsprintf
tiff.lib(tif_codec.obj) : error LNK2001: unresolved external symbol __imp___stdio_common_vsprintf
jpeg.lib(jdhuff.c.obj) : error LNK2019: unresolved external symbol __report_rangecheckfailure referenced in function jpeg_make_d_derived_tbl
jpeg.lib(jcmarker.c.obj) : error LNK2001: unresolved external symbol __report_rangecheckfailure
jpeg.lib(jcmaster.c.obj) : error LNK2001: unresolved external symbol __report_rangecheckfailure
jpeg.lib(jchuff.c.obj) : error LNK2001: unresolved external symbol __report_rangecheckfailure
jpeg.lib(jmemmgr.c.obj) : error LNK2019: unresolved external symbol __imp___stdio_common_vsscanf referenced in function _vsscanf_l
bin\vtkIOImage-7.1.dll : fatal error LNK1120: 5 unresolved externals
LINK failed. with 1120
looooo commented 7 years ago

I just tried to re-render, but conda smithy is not working for me right now. Can someone else do that? @Korijn the pinned version was officially increased: https://github.com/conda-forge/conda-forge.github.io/blob/master/scripts/pin_the_slow_way.py#L35

Korijn commented 7 years ago

@dfroger it looks like libjpeg and libtiff are clashing, odd. might just be a concurrency glitch, in need of a re-run.

@looooo alright, good to explicitly note that release. wrt conda-smithy, I also can't re-render.

dfroger commented 7 years ago

Seems that I can rerender, PR: #24

What is error do you have with rerender?

dfroger commented 7 years ago

Recently, I get this problem with rerender, now solved

looooo commented 7 years ago

the problem with re-rendering was a local repository added to the channels... It worked after commenting this channel from the .condarc file Now it should be re-rendered.

looooo commented 7 years ago

how to solve the timing issue?

looooo commented 7 years ago

no body else interested in this to be merged?

dfroger commented 7 years ago

Please note conda-forge has a global pinning policy for these common dependencies. @jakirkham

@Korijn Where is this global pinning policy "defined"? Is freetype pinned as a common dependency?

dfroger commented 7 years ago

It may be clearner to have two seperate PR, one to rerender the feedstock + workaround for time issue, and then another to update freetype.

Korijn commented 7 years ago

@dfroger https://github.com/conda-forge/conda-forge.github.io/blob/master/scripts/pin_the_slow_way.py

dfroger commented 7 years ago

@Korijn thanks, I'll read that!

Korijn commented 7 years ago

Looks like they pinned freetype to 2.7. So there's probably an automated PR from conda-forge coming soon.

looooo commented 7 years ago

Seems not to come very soon...

grlee77 commented 7 years ago

My apologies. I accidentally deleted the comments on which version to skip above and don't see a way to restore it. The suggestion I had made was to update this PR to use skip: True # [osx or py2k] and then rerender with conda-smithy so that master will build only Python 3.5 and 3.6. I can open a separate branch to build Python 2.

nicoddemus commented 7 years ago

CircleCI finished 🙌

nicoddemus commented 7 years ago

Awesome, thanks @looooo and @grlee77!

grlee77 commented 7 years ago

Thanks @looooo. I just created the py27 branch for this as well. Also, a quick heads-up: I think we will likely switch to the OpenGL2 backend in a subsequent PR as discussed in #29. Would this cause problems for either of you? We have had a couple issues raised due to the older OpenGL backend which is no longer the recommended default in VTK .

Korijn commented 7 years ago

No problem for us!