conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Rebuild for proj900 #235

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update proj900.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1959853236, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

@conda-forge-admin please rerender

hmaarrfk commented 2 years ago

@conda-forge/vtk this is ready for review

grlee77 commented 2 years ago

Hey @hmaarrfk, I'm not sure I have the full context here (or enough knowledge on recent conda-forge changes). I see you update to use CentOS 7 as described here, but the last announcements entry for Dec 2021 indicates this may already be the default?

Also, the existing build requirement line in meta.yaml setting sysroot_linux_64 is only being set for the osmesa case. Should that now be set for all linux64 builds?

I am unfamiliar with the new libglvnd CDT that as added. This was required mainly for compatibility with CentOS 7 or is needed specifically for libproj?

hmaarrfk commented 2 years ago

@conda-forge-admin please rerender

hmaarrfk commented 2 years ago

@grlee77 I'm pretty sure a CDT file regarding openGL got moved around. I'm testing making my changes a little "smaller"

hmaarrfk commented 2 years ago

I think the issue was that the bot accidentally upgraded linux64 to cos7 image

So after removing it, it seems to be workng smoothly. We can likely remove the CDT as well, but I think it is correct and likely more "future proof"

basnijholt commented 2 years ago

This is great! Thanks for investing your time to fix this 😃