Try add upstreamed patch to try_except python imports

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

Try add upstreamed patch to try_except python imports #286

Closed hmaarrfk closed 1 year ago

hmaarrfk commented 1 year ago

Xref: https://github.com/conda-forge/vtk-feedstock/pull/282 cc: @basnijholt

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 1 year ago

One of the Windows CI jobs had difficulty downloading the source code. Guessing this is just a hiccup. Also looks unrelated to this change. Restarted it

basnijholt commented 1 year ago

This is great! All CIs pass, still a draft?

hmaarrfk commented 1 year ago

i just wanted to make a proof of concept and help upstream test.

the devil is in the details, do you omit ffmpeg, like i did here, or create a vtk-ffmpeg subpackage