conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Rebuild for jpegturbo migration #288

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update jpeg_to_libjpeg_turbo.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4399242865, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 1 year ago

I wonder if the build errors in the osmesa builds are down to https://github.com/conda-forge/mesalib-feedstock/pull/42 which introduced using llvmdev. Error for reference: ImportError: libLLVM-15.so: cannot open shared object file: No such file or directory

/cc @hmaarrfk @rggjan

Tobias-Fischer commented 1 year ago

(in other words, do we need a run req on llvmdev in the mesalib builds?

hmaarrfk commented 1 year ago

Maybe......

hmaarrfk commented 1 year ago

Or a constraint

rggjan commented 1 year ago

I thought that should be added automatically according to https://github.com/conda-forge/mesalib-feedstock/pull/42#discussion_r1104406701 ?

hmaarrfk commented 1 year ago

@Tobias-Fischer It seems you had put it in the run section instead of the host section.

You can probably delete most of the things in the run section if you want to.

hmaarrfk commented 1 year ago

@rggjan the necessary dependencies for "running" are probably added automatically. For now, we don't have a way to specify the "build time" dependencies separately.

When we started to slim down packages for run-time, this somewhat broke the "compilation time" dependencies.

hmaarrfk commented 1 year ago

@conda-forge-admin please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/vtk-feedstock/actions/runs/4405585347.

rggjan commented 1 year ago

@rggjan the necessary dependencies for "running" are probably added automatically. For now, we don't have a way to specify the "build time" dependencies separately.

When we started to slim down packages for run-time, this somewhat broke the "compilation time" dependencies.

Oh, I understand. Thanks a lot for the explanation.

hmaarrfk commented 1 year ago

See https://github.com/conda-forge/conda-forge.github.io/issues/1880 for more context the later comments are more important I think.

hmaarrfk commented 1 year ago

Ok. This is weird. Now i believe that there is likely a missing run export.

hmaarrfk commented 1 year ago

could we maybe try to fix this in offending library before merging this too eagerly. it seems that we are missing a dependency on libllvm in mesalib

https://github.com/conda-forge/llvmdev-feedstock/blob/main/recipe/meta.yaml#L77

Tobias-Fischer commented 1 year ago

Certainly this is the right way to go @hmaarrfk. Just trying to debug here what is going on ..

hmaarrfk commented 1 year ago

great perfect. sorry, i just didn't want this to get "merged" accidentally.

this "turbo" migration has caused alot of these little cleanups to happen.

hmaarrfk commented 1 year ago

there is also a current proposal to move to llvm16, so i'm worried that it owuld break vtk :/

hmaarrfk commented 1 year ago

xref: https://github.com/conda-forge/mesalib-feedstock/pull/45

hmaarrfk commented 1 year ago

Nice! Thank you for the back and forth

jakirkham commented 1 year ago

Nicely done! 👏