Closed looooo closed 3 months ago
conda-forge-webservices[bot]
commented
3 months ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
looooo
commented
3 months ago btw. I am still not able to rerender with the latest conda-smithy, so I am using conda-smithy=3.32 here.
minrk
commented
3 months ago No problem, I rerendered with current conda-smithy. You can always ask the bot to do the rerenders if it's not working locally.
traversaro
commented
3 months ago As in the vtk 9.2.6 --> 9.3.0 update we are changing the ABI anyhow, could it make sense to add https://gitlab.kitware.com/vtk/vtk/-/commit/db8f9efca220c9d16a30958e179abae3379d0011 as a patch in this PR to also solve https://github.com/conda-forge/vtk-feedstock/issues/329 . There is no 9.4.0 release in sight, so if we merge 9.3.0 without this patch we may need to wait for a long time to be able to solve the expat pin again.
traversaro
commented
3 months ago If that is ok for you, I can prepare a PR to add the https://gitlab.kitware.com/vtk/vtk/-/commit/db8f9efca220c9d16a30958e179abae3379d0011 patch to the looooo:qt6_test branch.
minrk
commented
3 months ago @traversaro great idea! I added the patch and removed the expat pin, so we'll see
traversaro
commented
3 months ago @traversaro great idea! I added the patch and removed the expat pin, so we'll see
Thanks!
minrk
commented
3 months ago Thank you!
looooo
commented
3 months ago is there a migration created automatically?
minrk
commented
3 months ago it should show up at https://github.com/conda-forge/conda-forge-pinning-feedstock/pulls like this one, but if it doesn't shortly, we can open it by hand.
minrk
commented
3 months ago
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)