BUG: Fix bug with hash in filename

[larsoner]

Checklist

• [x] Used a personal fork of the feedstock to propose changes
• [x] Bumped the build number (if the version is unchanged)
• [x] Reset the build number to 0 (if the version changed)
• [x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [x] Ensured the license file is being packaged.

In adapting the build_variant mechanics for another repo (thanks for the clear comments and usage!) I noticed that the hashes for the VTK packages are just 1234567 (because I was getting these for mine, too):

Making these template substitutions seems to fix the problem for me in my packages. Opening this PR to see if they fix them here, too. In theory it should be visible in the last few lines of each CI run that it has been fixed, e.g. for my repo (this is in the middle of the run during installation for the test step):

If this does fix things, it's possible that it's an upstream bug, or just some misuse of templating, not sure :shrug:

EDIT: This also more closely matches the example in the docs: https://conda-forge.org/docs/maintainer/knowledge_base/

[larsoner]

@conda-forge-admin, please rerender

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[github-actions[bot]]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/vtk-feedstock/actions/runs/9847400200.

[Tobias-Fischer]

Many thanks for this, great work!

Can you please rerender locally to see what's going on?

[larsoner]

Same error locally both on this branch and on main so I don't think it's related to my changes here. 🙁

I then tried conda install conda-smithy=3.36.1 and conda-smithy rerender --no-check-uptodate -c auto and things were the same. Not sure how best to debug but I guess I'll need to open an upstream issue.

[larsoner]

https://github.com/conda-forge/conda-smithy/issues/1970

[larsoner]

No need for rerender as it turns out -- see https://github.com/conda-forge/conda-smithy/issues/1970#issuecomment-2216151190 but TL;DR is after making conda-smithy happy locally I got:

INFO:conda_smithy.configure_feedstock:No changes made. This feedstock is up-to-date.

[larsoner]

... and looking at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=973199&view=logs&jobId=1e116cca-0a74-5ed2-d113-bc13ce542b6b&j=1e116cca-0a74-5ed2-d113-bc13ce542b6b&t=d07b326e-1935-5427-8823-0a396090daa0 for example the hash appears to be in there:

[Tobias-Fischer]

Any objections to merging?