search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Rebuild with boost pinned #338

Closed conda-forge-admin closed 2 months ago

conda-forge-admin commented 2 months ago

hmaarrfk:

It seems to me that likely this should be migrated with every version of boost. But currently we don't have a pinning on libboost headers:

https://github.com/conda-forge/petpvc-feedstock/pull/11 https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6338

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

hmaarrfk commented 2 months ago

@conda-forge-admin please rerender

hmaarrfk commented 2 months ago

A few things I found:

-- Could NOT find freetype (missing: freetype_DIR)

but maybe this is a bug upstream....

2024-08-25T15:40:31.4107104Z -- Could NOT find freetype (missing: freetype_DIR)
2024-08-25T15:40:31.4420853Z -- Found Freetype: /home/conda/feedstock_root/build_artifacts/vtk_1724600134513/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/libfreetype.so (found version "2.12.1")

I'm also not sure what this means:

2024-08-25T15:40:33.6337239Z -- Found Boost: /home/conda/feedstock_root/build_artifacts/vtk_1724600134513/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/cmake/Boost-1.84.0/BoostConfig.cmake (found version "1.84.0")
2024-08-25T15:40:33.6357850Z -- Performing Test HAVE_BOOST_SHARED_DYNAMIC_CAST
2024-08-25T15:40:33.9820408Z -- Performing Test HAVE_BOOST_SHARED_DYNAMIC_CAST - Failed
hmaarrfk commented 2 months ago

It seems in fact that this doesn't link to boost:

2024-08-25T16:58:25.8984590Z WARNING (vtk-base): dso library package conda-forge/osx-64::libboost==1.84.0=hcca3243_5 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)

we will have to wait till libboost_headers gets added to the global pinning.

Tobias-Fischer commented 2 months ago

Should I change the status to "draft" in the meantime?

hmaarrfk commented 2 months ago

yeah, if you can comment on my PR for the pinning to give more context that would help.

hmaarrfk commented 2 months ago

you'll just have to rerender when the pinning is live.