search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Python 2/3 #39

Closed jakirkham closed 7 years ago

jakirkham commented 7 years ago

Combine the Python 2 and Python 3 builds back together again. Re-render with conda-smithy 2.4.0 to get matrix builds for CircleCI.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 7 years ago

The diff here looks really weird for some reason. Locally I can only see the CI configuration file changes and the change to meta.yaml's skip.

jakirkham commented 7 years ago

Merging with master seems to have fixed it.

jakirkham commented 7 years ago

Ok, this should be good to go.

jakirkham commented 7 years ago

@Korijn, would it be alright if we merge this?

Korijn commented 7 years ago

Yes, for sure!

jakirkham commented 7 years ago

Should add that I deleted the py2 branch as its contents are now included in master thanks to the merge commit here. So the history remains intact.