search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Enable Travis CI #42

Closed jakirkham closed 6 years ago

jakirkham commented 7 years ago

Fixes https://github.com/conda-forge/vtk-feedstock/issues/10 Closes https://github.com/conda-forge/vtk-feedstock/pull/34

Attempts to get macOS packages built by enabling Travis CI.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Korijn commented 7 years ago

This is a long shot, but the most recent version of ninja (v1.8.2) has the following line in its changelog:

Use POSIX_SPAWN_USEVFORK with glibc, makes some full builds twice as fast #1182

Since we are using ninja v1.7.2, bumping it might do the trick? For this purpose, I opened https://github.com/conda-forge/ninja-feedstock/pull/5

On a different note, I read in the Kitware blog that ninja defaults to building with cpu_cores + 2 jobs.

Korijn commented 7 years ago

Now that ninja v1.8.2 is out, we can just retrigger the build to see if it makes any difference. I've restarted the Travis CI build.

I would recommend switching back to just ninja install and letting ninja determine the amount of parallelism.

Korijn commented 7 years ago

Still getting timeouts...

More recent versions of clang (that come with more recent versions of xcode) are also known to have faster compile times. Why is conda-forge on osx_image: xcode6.4? It seems osx_image: xcode9 is much more recent, and might provide faster build times through newer versions of clang.

jakirkham commented 7 years ago

Why is conda-forge on osx_image: xcode6.4?

The reasoning is similar to why we use CentOS 6 for Linux builds. We try to build against the oldest OS that we want to support. That way we can guarantee that everything should work on that OS or any newer version. This xcode6.4 has macOS 10.10, but includes the SDK for macOS 10.9. As conda-forge started out supporting macOS 10.9 and we haven't discussed changing the lowest version of the OS, we continue to try to do so. Admittedly at some point this will have to change this.

...might provide faster build times through newer versions of clang.

That's certainly something we can explore. Though the macOS version we target and the clang version used can be varied independently. We build clang in conda-forge in a package called clangdev. So we could try using that. We would need to require libcxx as well for C++ support.

Korijn commented 6 years ago

I'm closing this as it doesn't look like VTK will ever build within the Travis CI build time limit constraints.