Closed marcelotrevisani closed 6 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@Korijn , could you please review and merge that for me?
Looks like you need to update our build scripts to support vtk 8.
@Korijn Could you help me please? In Windows the MSVC compiler has to be at least MSVC2012 to build VTK 8.0.1, in Python 2 at AppVeyor the build is failing because the system is trying to build the VTK 8.0.1 using the same compiler as used for Python 2. I was wondering if exist a way to set the system to use at least MSVC 2012 instead of the same compile as Python
You would need to also rebuild Python so I am afraid that is not possible/wise. Has VTK8 dropped py2.7 support?
@Korijn VTK 8.0.1 still have support for Python 2.7 . Actually, you just have to configure the compiler flag to build wrappers for python 2 or 3
As you can see here: https://www.vtk.org/Wiki/VTK/Python_Wrapping_FAQ
The VTK master branch is regularly tested with Python 2.7 and 3.4, and VTK 7 should work with 2.5, 2.6, 2.7, and 3.2+. Versions of VTK prior to 7.0 will only work with Python 2.
@jakirkham do you know of a solution to this one?
You could try using msys2
packages to compile it on Python 2.7. Not really that familiar with using them though. Would reach out to @mingwandroid who might be able to advise.
@jakirkham Do you have any example how do I do that?
@mingwandroid @jakirkham , does anyone have a clue here? If not I will drop the support for Python 2 in this recipe
I would drop Windows Python 2 support here personally. It's not supported upstream despite what they claim.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
<two spaces>#<one space>[<expression>]
form.see lines [19]@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
<two spaces>#<one space>[<expression>]
form.see lines [19, 28]Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Just to be explicit, I agree with Ray. We had to do the same thing with protobuf because they kept letting C++0x and C++11 features slip in, which are not compatible with VS2008. Similar story with OpenCV (though they at least confirmed they have no interest in targeting VS2008). Though would encourage you to raise an issue upstream with a link to the failed builds.
@Korijn or @tadeu , could you please review and merge that for me? thanks
Reopening to trigger the new build in appveyor
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
<two spaces>#<one space>[<expression>]
form.see lines [23]Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@tadeu , anything else? if not, could you please merge that for me? thanks
Nice work @marcelotrevisani, thnx for pursuing this!
Update the VTK version to 8.0.1