search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

Update VTK to 8.1.0 #48

Closed marcelotrevisani closed 6 years ago

marcelotrevisani commented 6 years ago

Updated the vtk version to VTK 8.1.0

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

marcelotrevisani commented 6 years ago

@tadeu do you know why this error occurred in appveyor? https://ci.appveyor.com/project/conda-forge/vtk-feedstock/build/1.0.129/job/wi9wdnq374gsut0t

The batch file cannot be found.

marcelotrevisani commented 6 years ago

cc: @Korijn @jakirkham

nicoddemus commented 6 years ago

Needs a rerender, hold on

nicoddemus commented 6 years ago

@conda-forge-admin, please rerender

marcelotrevisani commented 6 years ago

@nicoddemus Thank you! 👍

nicoddemus commented 6 years ago

@marcelotrevisani in the future please open PRs from branches in your fork instead of branches in the main repository: currently conda-forge will publish any successful builds from any branch in the main repository, which means for example 8.1.0 has already been published for the other platforms even though we didn't merge this PR yet.

marcelotrevisani commented 6 years ago

@nicoddemus I didn't know that. Thanks for the advice! I will remember about that! 👍

nicoddemus commented 6 years ago

Sure thing! 😄

jakirkham commented 6 years ago

Could you actually go ahead and move this work to your fork and open a fresh PR before proceeding, @marcelotrevisani? Would like to avoid a plethora of incomplete packages getting uploaded to the channel before getting this right. Thanks.

nicoddemus commented 6 years ago

Could you actually go ahead and move this work to your fork and open a fresh PR before proceeding, @marcelotrevisani? Would like to avoid a plethora of incomplete packages getting uploaded to the channel before getting this right. Thanks.

@jakirkham I suggest we let the current builds finish because I suspect Windows only failed because we needed to rerender the feedstock, so once it completes all packages will be uploaded and we will be set.

If on the other hand Windows fails for some reason again, then I agree completely, we should move this to a fresh PR to sort out the issue.

marcelotrevisani commented 6 years ago

Should I create another PR from my fork repository or just merge that as it is?

jakirkham commented 6 years ago

Let’s go ahead and merge it. My comment was more directed at further revisions of this PR, of which none are needed.