search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

[NO MRG] cb3 update #50

Closed isuruf closed 6 years ago

isuruf commented 6 years ago

@msarahan, do you know why the matrix for vtk_with_osmesa doesn't work?

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

msarahan commented 6 years ago

I think, but have not completely confirmed, that the issue is that your yaml file is not being automatically converted to boolean values correctly. I think they're coming out as simply strings, in which case "True" and "False" are both True in the boolean sense. I find that behavior unintuitive, and will look into a fix.

msarahan commented 6 years ago

That was an issue, but not the only one. The real issue was that selectors were being applied prior to detecting used variables, and thus were not being looped over. I'll fix that in the next bugfix release.

isuruf commented 6 years ago

Thanks for looking into this. Is there some change we have to do in conda-smithy?

msarahan commented 6 years ago

I don't think any change to conda-smithy will be necessary. Purely an implementation detail in conda-build.

marcelotrevisani commented 6 years ago

Can we close this merge request? I think the matrix with vtk_with_osmesa was already fixed with the #51

@isuruf

This branch is behind our master as well

jakirkham commented 6 years ago

There are some contents that should be pulled from this into probably a fresh PR as they are needed for conda-build 3 support. Also suspect some new features that @isuruf added may help address issue ( https://github.com/conda-forge/vtk-feedstock/issues/47 ). If you have time to take this on, would encourage you to do so.

jakirkham commented 6 years ago

Now that PR ( https://github.com/conda-forge/vtk-feedstock/pull/54 ) is merged are we good to close this or were there other things we should be including from it?