conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

rerender conda-smity 3.1.1 #54

Closed looooo closed 6 years ago

looooo commented 6 years ago

Fixes https://github.com/conda-forge/vtk-feedstock/issues/47

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

Thanks for doing this, @looooo. Also thanks @isuruf for doing all the work necessary to get it to this point (which was not insignificant for those unaware).

Looks like one of the CircleCI macOS builds passed. Let's see how the rest do.

isuruf commented 6 years ago

I cancelled the CI to avoid wasting 9 hours of CI time

jakirkham commented 6 years ago

Thank you. Sorry for leaving those up there.

looooo commented 6 years ago

so this works. great. thanks for your efforts @isuruf to make this possible. regarding the wrong syntax in conda-forge.yml: I applied the correct syntax before rerendering. But the change was not included in the commit. no idea.

looooo commented 6 years ago

@jakirkham how to move forward? I would love to see this merged, as it is one of the main show-stoppers I currently have.

jakirkham commented 6 years ago

Thanks @looooo. Have not forgotten. ;)

So have added a fixes note for the macOS build issue. Will ping some people over there to review. Expect this will be merged in short order. :)

jakirkham commented 6 years ago

Should add this does appear to be using the right macOS SDK AFAICT. Picks up OpenGL from it for instance.

jakirkham commented 6 years ago

Planning on merging tomorrow evening if there are no comments.

jakirkham commented 6 years ago

Hmm...seeing a new error cropping up from conda-build. Seems to be treating jpeg in a weird way. Is this fixed with conda-build version 3.9.2, @msarahan? If so, would it be alright to merge PR ( https://github.com/conda-forge/conda-build-feedstock/pull/45 )?

Traceback (most recent call last):
  File "/opt/conda/lib/python3.6/site-packages/conda_build/environ.py", line 706, in get_install_actions
    actions = install_actions(prefix, index, specs, force=True)
  File "/opt/conda/lib/python3.6/site-packages/conda/common/io.py", line 46, in decorated
    return f(*args, **kwds)
  File "/opt/conda/lib/python3.6/site-packages/conda/plan.py", line 541, in install_actions
    txn = solver.solve_for_transaction(prune=prune, ignore_pinned=not pinned)
  File "/opt/conda/lib/python3.6/site-packages/conda/core/solve.py", line 505, in solve_for_transaction
    force_remove, force_reinstall)
  File "/opt/conda/lib/python3.6/site-packages/conda/core/solve.py", line 438, in solve_for_diff
    final_precs = self.solve_final_state(deps_modifier, prune, ignore_pinned, force_remove)
  File "/opt/conda/lib/python3.6/site-packages/conda/core/solve.py", line 318, in solve_final_state
    conflicting_specs = r.get_conflicting_specs(tuple(final_environment_specs))
  File "/opt/conda/lib/python3.6/site-packages/conda/resolve.py", line 705, in get_conflicting_specs
    reduced_index = self.get_reduced_index(specs)
  File "/opt/conda/lib/python3.6/site-packages/conda/resolve.py", line 254, in get_reduced_index
    specs, features = self.verify_specs(specs)
  File "/opt/conda/lib/python3.6/site-packages/conda/resolve.py", line 172, in verify_specs
    raise ResolvePackageNotFound(bad_deps)
conda.exceptions.ResolvePackageNotFound: 
  - jpeg[version='>=9,<10.0a0']
  - vtk==8.1.0=py27he461554_202
  - jpeg[version='>=9,<10.0a0']

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 6, in <module>
    sys.exit(conda_build.cli.main_build.main())
  File "/opt/conda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 420, in main
    execute(sys.argv[1:])
  File "/opt/conda/lib/python3.6/site-packages/conda_build/cli/main_build.py", line 411, in execute
    verify=args.verify)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/api.py", line 199, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 2123, in build_tree
    test(pkg, config=metadata.config, stats=stats)
  File "/opt/conda/lib/python3.6/site-packages/conda_build/build.py", line 1878, in test
    channel_urls=tuple(metadata.config.channel_urls))
  File "/opt/conda/lib/python3.6/site-packages/conda_build/environ.py", line 708, in get_install_actions
    raise DependencyNeedsBuildingError(exc, subdir=subdir)
conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'vtk==8.1.0=py27he461554_202', "jpeg[version='>=9,<10.0a0']"}

ref: https://circleci.com/api/v1.1/project/github/conda-forge/vtk-feedstock/395/output/104/0?file=true

cc @stuarteberg (as we discussed something similar the other day)

stuarteberg commented 6 years ago

The problem is that conda-build translates - jpeg 9* to - jpeg >=9,<10.0a0, which looks correct, but jpeg uses a weird versioning scheme. Our current version of jpeg is 9b, which is interpreted as 9.beta by PEP440 (more-or-less). According to PEP440, beta versions are LESS than non-beta, so 9b < 9.0 and therefore 9b does not satisfy >=9,<10.0a0.

The quick fix is to change the jpeg requirement in this recipe: >=9a,<10 should work.

jakirkham commented 6 years ago

We might be able to drop the pinning altogether since PR ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/46 ) went in. Though it would be good if someone can confirm whether this is true or not. Will work up a PR for discussion.

ref: https://conda.io/docs/user-guide/tasks/build-packages/variants.html#pinning-at-the-variant-level

jakirkham commented 6 years ago

Restarting the builds on master to see if recent conda-build releases fixed the previously seen issue.

cc @ivoflipse

jakirkham commented 6 years ago

Looks like they all built.

looooo commented 6 years ago

great! thanks for your work @jakirkham @isuruf