Closed jakirkham closed 6 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please re-render.
@conda-forge-admin, please re-render.
Appears the pinnings may not be tight enough in some cases. Here's a loading error with freetype
and libpng
.
Traceback (most recent call last):
File "/Users/distiller/miniconda3/conda-bld/vtk_1524956796987/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.5/site-packages/vtk/vtkRenderingFreeType.py", line 5, in <module>
from .vtkRenderingFreeTypePython import *
ImportError: dlopen(/Users/distiller/miniconda3/conda-bld/vtk_1524956796987/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.5/site-packages/vtk/vtkRenderingFreeTypePython.so, 2): Library not loaded: @rpath/libpng16.16.dylib
Referenced from: /Users/distiller/miniconda3/conda-bld/vtk_1524956796987/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/libfreetype.6.dylib
Reason: Incompatible library version: libfreetype.6.dylib requires version 51.0.0 or later, but libpng16.16.dylib provides version 49.0.0
Edit: ...or at least some rebuilding needs to occur with the newer versions in our pinning file.
It's because libpng
pinning was wrong in freetype
. This is fixed with https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/52
@isuruf @jakirkham if this is fixed now, can you rerender?
Itβs not yet fixed. We are discussing in PR ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/52 ).
@conda-forge-admin, please re-render.
Will give this another go this evening given new pinnings are out.
Ran into issue ( https://github.com/conda-forge/conda-smithy/issues/775 ). Submitted PR ( https://github.com/conda-forge/conda-smithy/issues/785 ) to fix it. This seems to work based on local testing.
Edit: Fix included in conda-smithy
version 3.1.5
.
So this looks ok thus far, but it will take a while to build. We can let it build through. Though given the length of the build, we might need to do the merge Friday evening (assuming all goes well π) to avoid swamping CIs during the day.
All packages are now deployed. π Enjoy. π
Tries to use the variant pinning strategy described in the docs. Not sure if this is the best way to do this. Also unsure as to whether it can be simplified/relaxed further. Feedback welcome.
Checklist
0
(if the version changed)conda-smithy
Closes https://github.com/conda-forge/vtk-feedstock/issues/62
ref: https://github.com/conda-forge/vtk-feedstock/pull/54
cc @isuruf @msarahan