use system lz4 and netcdf - Githubissues

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.

BSD 3-Clause "New" or "Revised" License

13 stars 64 forks source link

use system lz4 and netcdf #57

Closed looooo closed 6 years ago

looooo commented 6 years ago

see #55

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

Please see commit ( https://github.com/conda-forge/vigra-feedstock/commit/a1a3cd48fc0d74998b5cf968226e974aeb9d2519 ) for how to get HDF5 to work on Windows.

Edit: Also will need to remove the unix selector from hdf5.

jakirkham commented 6 years ago

Should add jsoncpp is also available for Windows.

jakirkham commented 6 years ago

Also this warning showed up in the Linux log.

CMake Warning:
  Manually-specified variables were not used by the project:

    VTK_USE_SYSTEM_LZMA

ref: https://circleci.com/gh/conda-forge/vtk-feedstock/433

jakirkham commented 6 years ago

@conda-forge-admin, please re-render.

jakirkham commented 6 years ago

Pushed a few fixes to your PR, @looooo. Hope that is ok. Think that should fix the Windows issue.

jakirkham commented 6 years ago

Thanks @looooo.

If you see anything that is off, please let me know. We can deal with it in another PR. Trying to get vtk into good shape this weekend while CIs have low usage.