Generate an egg-info file and test the pkg_resources finds it

[mwcraig]

Checklist

• [x] Used a fork of the feedstock to propose changes
• [x] Bumped the build number (if the version is unchanged)

This PR is intended to fix the issue described in https://github.com/enthought/mayavi/issues/652, which occurs because because the conda-forge vtk currently doesn't produce anything that pkg_resources can find.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[christianbrodbeck]

Looks like it needs setuptools added as dependency

===== testing package: vtk-8.1.1-py36hdceb404_202 =====
running run_test.py
Traceback (most recent call last):
  File "/Users/distiller/miniconda3/conda-bld/vtk_1531645356383/test_tmp/run_test.py", line 5, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
Tests failed for vtk-8.1.1-py36hdceb404_202.tar.bz2 - moving package to /Users/distiller/miniconda3/conda-bld/broken
WARNING:conda_build.build:Tests failed for vtk-8.1.1-py36hdceb404_202.tar.bz2 - moving package to /Users/distiller/miniconda3/conda-bld/broken
removing: vtk-8.1.1-py36hdceb404_202.tar.bz2
TESTS FAILED: vtk-8.1.1-py36hdceb404_202.tar.bz2
Exited with code 1

[mwcraig]

Thanks @christianbrodbeck!

[jakirkham]

Would it make sense to upstream this change?

cc @demarle

[mwcraig]

Any object to merging this, @jakirkham? I don't object at all to it going upstream but would like to get vtk working with mayavi

[msarahan]

I would argue that this should not be upstreamed. vtk as a pip package has an equivalent of this, and that's what mayavi is expecting. The wheels are built completely differently. Because we build vtk as a traditional library, we must add this for usage with things that think it's a python package. This is really a packaging thing, and does not belong in vtk proper.

CC @jcfr, who I discussed this with at SciPy.

[jcfr]

:+1:

May be worth adding a comment in the build script indicating that this is required to support package making use of __requires__ (e.g mayavi). See https://setuptools.readthedocs.io/en/latest/pkg_resources.html#workingset-objects

[jcfr]

:+1:

[Cadair]

can this now be merged? :)

[mwcraig]

Just did it...

[jakirkham]

Friendly note: Normally I try not to merge anything here until the US evening as the builds take several hours to complete, which is a bit rough on queue when people are actively using it. Something to keep in mind.

[mwcraig]

oops; should have thought about that....

[grlee77]

Unless I am mistaken, builds didn't show up at https://anaconda.org/conda-forge/vtk/files because both this PR and the recently merged #63 bumped the build number to 2. I guess we will need a new PR to bump the build number and rebuild...

[jakirkham]

Ouch! Yep, you're right. This elucidates it.

[mwcraig]

:facepalm: -- @jakirkham do you want the honors of opening the PR to bump the build number or shall I? I think we could open that PR and merge before waiting for CI to complete since all we are doing is bumping the build number and we already know the build passes. Agree?

[grlee77]

we could open that PR and merge before waiting for CI to complete

yeah, I think you could do that. (potentially waiting to make the PR until the evening/night to reduce the CI load during business hours)