search

conda-forge / vtk-feedstock

A conda-smithy repository for vtk.
BSD 3-Clause "New" or "Revised" License
13 stars 64 forks source link

test #73

Closed looooo closed 5 years ago

looooo commented 5 years ago

Checklist

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

looooo commented 5 years ago

OSMESAFalse fails because of:

$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: $BUILD_PREFIX/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib64/libxcb.so.1: undefined reference to `XauGetBestAuthByAddr'

and there is a warning:

$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: warning: libXau.so.6, needed by $BUILD_PREFIX/bin/../x86_64-conda_cos6-linux-gnu/sysroot/usr/lib64/libxcb-glx.so.0, not found (try using -rpath or -rpath-link)

but

    xorg-kbproto:    1.0.7-h14c3975_1002        conda-forge
    xorg-libice:     1.0.9-h14c3975_1004        conda-forge
    xorg-libsm:      1.2.3-h4937e3b_1000        conda-forge
    xorg-libx11:     1.6.6-h14c3975_1000        conda-forge
    xorg-libxau:     1.0.8-h14c3975_1006        conda-forge
    xorg-libxdmcp:   1.1.2-h14c3975_1007        conda-forge
    xorg-libxt:      1.1.5-h14c3975_1002        conda-forge
    xorg-xproto:     7.0.31-h14c3975_1007       conda-forge
looooo commented 5 years ago

Can we merge this in this state. VTK_WITH_OSMESATrue is not yet working, but I guess it's better to merge it this way, than using cdt's for vtk with mesalib (like I tried with a earlier commit)

I really need a vtk-py37 package to proceed with porting some libs to new-compilers / py37. Would be nice if someone have a look at this.

looooo commented 5 years ago

@conda-forge/core can we merge this PR? It's really annoying that I cannot update other recipes to new compilers because of this PR is not merged.

scopatz commented 5 years ago

Hmm it seems to be failing a lot of builds

looooo commented 5 years ago

I guess vtk with mesalib never worked the way it should. The tool-chain-builds simple allowed to link to system libs. Now linking to system libs is avoided, or can be done with cdt's. To get the builds depending on mesalib working additional work is necessary. We can do this later on.

But I think conda-forge should decide to take the cdt approach for now. We can try to minimize system libs later on.

Btw.: All failing builds depend on mesalib.

mariusvniekerk commented 5 years ago

Yeah let's use the cdt approach for this.

looooo commented 5 years ago

I will add one patch to fix a problem with pyside2: https://gitlab.kitware.com/vtk/vtk/commit/c1cce50d86d6b19da56b7c747ee48da99a24449f

So please wait with merging.

looooo commented 5 years ago

Is the system GL library too old and does not support all opengl2 stuff?

mingwandroid commented 5 years ago

Unlikely. Please check for yourself though.

looooo commented 5 years ago

I reverted back to vtk8.1.2 as this version was already working. (At least for OSMESAFalse)

looooo commented 5 years ago

Should we merge? This way we have at least a vtk package for py37.

scopatz commented 5 years ago

ping @conda-forge/vtk! You don't need to worry about azure builds and the OSMESA ones are up to you

grlee77 commented 5 years ago

I am fine with having builds without Mesa for now. If anyone has the time and inclination to fix and test the Mesa support, they can add it back in later. Do any of the other maintainers disagree?

Also, rather than just letting those builds fail, shouldn't we just remove the OSMESA=True case from conda_build_config.yaml?

ivoflipse commented 5 years ago

I'd rather see us being able to release a version of VTK than blocking a release because of Mesa

looooo commented 5 years ago

Also, rather than just letting those builds fail, shouldn't we just remove the OSMESA=True case from conda_build_config.yaml?

Ok, done here: https://github.com/conda-forge/vtk-feedstock/pull/73/files#diff-8926f6e7808be490ec92ac38016ab868R3 and rerendered. Now there are no WITH_OSMESATRUE builds anymore.