warpx v24.02 - Githubissues

regro-cf-autotick-bot commented 9 months ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

[ ] Dependencies have been updated if changed: see upstream
[ ] Tests have passed
[ ] Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

h5py
unyt
yt
gitpython
openpmd-viewer
arm_pyart
sphinx_rtd_theme
pybtex
requests
matplotlib
dill
libensemble
mashumaro
openpmd-api
pytorch
mpi4py
config
pandas

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7752816995, please use this URL for debugging.}

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: failed

Thus the PR was not passing and not merged.

ax3l commented 9 months ago

Seeing an issue linking the final executable on Windows cc @WeiqunZhang

[364/744] C:\Windows\system32\cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\app_2d.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- %BUILD_PREFIX%\Library\bin\lld-link.exe  CMakeFiles\app_2d.dir\Source\main.cpp.obj  /out:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console  lib\libwarpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib  lib\ablastr_2d.lib  %PREFIX%\Library\lib\amrex_2d.lib  %PREFIX%\Library\lib\libomp.lib  %PREFIX%\Library\lib\fftw3.lib  %PREFIX%\Library\lib\openPMD.lib  %PREFIX%\Library\lib\adios2_cxx11.lib  lib\buildInfopyWarpX_2d.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && C:\Windows\system32\cmd.exe /C "cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe D:/bld/warpx_1706926672986/work/build/bin/warpx.2d && cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe D:/bld/warpx_1706926672986/work/build/bin/warpx.2d""
FAILED: bin/warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe 
C:\Windows\system32\cmd.exe /C "cd . && %BUILD_PREFIX%\Library\bin\cmake.exe -E vs_link_exe --intdir=CMakeFiles\app_2d.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests  -- %BUILD_PREFIX%\Library\bin\lld-link.exe  CMakeFiles\app_2d.dir\Source\main.cpp.obj  /out:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console  lib\libwarpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib  lib\ablastr_2d.lib  %PREFIX%\Library\lib\amrex_2d.lib  %PREFIX%\Library\lib\libomp.lib  %PREFIX%\Library\lib\fftw3.lib  %PREFIX%\Library\lib\openPMD.lib  %PREFIX%\Library\lib\adios2_cxx11.lib  lib\buildInfopyWarpX_2d.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && C:\Windows\system32\cmd.exe /C "cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe D:/bld/warpx_1706926672986/work/build/bin/warpx.2d && cd /D %SRC_DIR%\build && %BUILD_PREFIX%\Library\bin\cmake.exe -E create_symlink warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe D:/bld/warpx_1706926672986/work/build/bin/warpx.2d""
LINK: command "%BUILD_PREFIX%\Library\bin\lld-link.exe CMakeFiles\app_2d.dir\Source\main.cpp.obj /out:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.exe /implib:lib\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib /pdb:bin\warpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console lib\libwarpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib lib\ablastr_2d.lib %PREFIX%\Library\lib\amrex_2d.lib %PREFIX%\Library\lib\libomp.lib %PREFIX%\Library\lib\fftw3.lib %PREFIX%\Library\lib\openPMD.lib %PREFIX%\Library\lib\adios2_cxx11.lib lib\buildInfopyWarpX_2d.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST:EMBED,ID=1" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: __declspec(dllimport) class std::array<struct omp_lock_t, 128> amrex::OpenMP::omp_locks
>>> referenced by libwarpx.2d.NOMPI.OMP.DP.PDP.OPMD.PSATD.QED.lib(WarpXParticleContainer.cpp.obj):(public: class amrex::BaseFab<double> & __cdecl amrex::BaseFab<double>::lockAdd<1>(class amrex::BaseFab<double> const &, class amrex::Box const &, class amrex::Box const &, int, int, int))

I see the symbol export for omp_locks https://github.com/AMReX-Codes/amrex/pull/3696 and wonder what's missing.

ax3l commented 9 months ago

Checking for build chain compiler / OpenMP impl mismatches:

WarpX (here)

    llvm-openmp:     17.0.6-h91493d7_0         conda-forge
...
-- The C compiler identification is Clang 17.0.6 with MSVC-like command-line
-- The CXX compiler identification is Clang 17.0.6 with MSVC-like command-line
...
-- Found OpenMP_CXX: -Xclang -fopenmp (found version "5.1") 
-- Found OpenMP: TRUE (found version "5.1") found components: CXX

AMReX

https://github.com/conda-forge/amrex-feedstock/pull/15

    llvm-openmp:  17.0.6-h91493d7_0        conda-forge
...
-- The C compiler identification is Clang 17.0.6 with MSVC-like command-line
-- The CXX compiler identification is Clang 17.0.6 with MSVC-like command-line
...
-- Found OpenMP_CXX: -Xclang -fopenmp (found version "5.1") 
-- Found OpenMP: TRUE (found version "5.1") found components: CXX

Looks legit.

conda-forge / warpx-feedstock

warpx v24.02 #80

Dependency Analysis

Packages found by source code inspection but not in the meta.yaml:

Checking for build chain compiler / OpenMP impl mismatches:

WarpX (here)

AMReX