ENH first version - Githubissues

conda-forge / webservices-dispatch-action

a GitHub action to rerender conda-forge feedstocks

BSD 3-Clause "New" or "Revised" License

2 stars 10 forks source link

ENH first version #1

Closed beckermr closed 4 years ago

beckermr commented 4 years ago

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

beckermr commented 4 years ago

@isuruf can you take a look here? For whatever reason the token they give us is not allowing me to push to forks.

isuruf commented 4 years ago

After reading https://help.github.com/en/actions/reference/events-that-trigger-workflows#pull-request-events-for-forked-repositories-2 it looks like it is expected. Maybe we should ask github if they can extend the permissions to write on fork repo branch in addition to read on base repo.

beckermr commented 4 years ago

Right but I assumed that if I had "Allow edits from maintainers." checked, then it would let me write.

beckermr commented 4 years ago

Something is even weirder here though. I cannot even comment on a PR in the same repo.

beckermr commented 4 years ago

OK so it works for non-forked PRs. I don't quite understand how I didn't hit this issue with status and check_suite events, but I guess these are always sent to the default branch. The docs say pull requests go to the base repo as well, but I guess that is not quite what they mean.

This PR will have to be on ice until the permissions can be changed. Certain pull requests events like labels should have write permissions since only maintainers can create labels in the first place.

isuruf commented 4 years ago

Looks good to me. Thanks for working on this.

Btw, as this is now using repository_dispatch events, can we change the name of this action to something like, webservice-dispatch-action so that we can add more functionality if necessary later on.

beckermr commented 4 years ago

I'm going to merge and then swap the names in another PR.