search

conda-forge / webservices-dispatch-action

a GitHub action to rerender conda-forge feedstocks
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

Update to Python 3.10 (using repo branch) #20

Closed jakirkham closed 1 year ago

jakirkham commented 1 year ago

xref: https://github.com/conda-forge/webservices-dispatch-action/pull/19

beckermr commented 1 year ago

Ahhh this fails since I removed the branch from the test repo.

jakirkham commented 1 year ago

I see. The rerender-live-test is missing from cf-autotick-bot-test-package-feedstock, right? Can add that branch there. Was there anything special about that branch (rerender-live-test) or would just creating one adjacent to main be sufficient?

jakirkham commented 1 year ago

If you have a cloned copy of the repo, it may still have that remote branch (assuming its changes are important). Could also check git reflog or git fsck

beckermr commented 1 year ago

A branch on the repo will cause uploads. I think we need a branch from a fork.

jakirkham commented 1 year ago

That can be overridden

beckermr commented 1 year ago

That won't work here due to other tests run on this repo. Maybe the extra uploads are ok. They only happen once.

jakirkham commented 1 year ago

That won't work here due to other tests run on this repo

Could you please clarify?

Maybe the extra uploads are ok. They only happen once.

Was also wondering about this

Any thoughts on this question?

Was there anything special about that branch (rerender-live-test) or would just creating one adjacent to main be sufficient?

beckermr commented 1 year ago

We have automated tests of the webservices heroku app that require uploads on all branches.

Our ci will only do uploads once so if we use a branch we only get one extra package.

Afaik there was nothing special about that branch.

Note that if we only test rerendering from a branch on the same repo then we could miss bugs from rerendering on forks.

jakirkham commented 1 year ago

Created rerender-live-test on cf-autotick-bot-test-package and canceled CI to avoid package uploads

Have power cycled CI for this PR to see if that fixes the issue