search

conda-forge / webservices-dispatch-action

a GitHub action to rerender conda-forge feedstocks
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

Need a message if the GitHub Actions files cannot be updated #50

Closed njzjz closed 6 months ago

njzjz commented 6 months ago

When the GitHub Actions files need to be updated, and the web service action doesn't have permission, it doesn't give any messages. The contributors may easily ignore the fact that they should rerender and push the repository locally.

Ideally, a comment should be made in this case, notifying the contributors that they need to update these files manually.

xref: https://github.com/conda-forge/pytorch-cpu-feedstock/pull/224#issuecomment-1994975034

beckermr commented 6 months ago

Right. We just reject the changes so it works but we should post a message on the PR.

jakirkham commented 6 months ago

Yeah it might be worth putting in the docs and then the message can link to the docs

jakirkham commented 6 months ago

Where in the code do we reject the changes?

beckermr commented 6 months ago

We have to or the push to the repo fails. It is in main maybe? Or in the rerender model

jakirkham commented 6 months ago

Sorry, understand why

Was asking where (in the code)

Trying to figure out where we can make the GH comment happen

njzjz commented 6 months ago

Here,

https://github.com/conda-forge/webservices-dispatch-action/blob/bb41922e55d365408622fa1810f971682423c9b1/webservices_dispatch_action/rerendering.py#L38-L46

beckermr commented 6 months ago

We can add a comment to the rerender error.

beckermr commented 6 months ago

closed by https://github.com/conda-forge/webservices-dispatch-action/pull/51