search

conda-forge / webservices-dispatch-action

a GitHub action to rerender conda-forge feedstocks
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

introduce ruff for lint & format and pixi #79

Closed wolfv closed 2 months ago

wolfv commented 2 months ago

I am trying to introduce pixi for better lockfile management and safer updates. Also included the usual ruff / mypy combo.

wolfv commented 2 months ago

We could automate that with the pixi github action and have a lockfile to be able to roll back to some state?

Isn't it currently just always updating everything on a weekly basis?

I was also hoping to introduce mypy in order to catch a certain class of bugs early (renamed functions, etc.).

Currently I am splitting this up and cleaning the Dockerfile.

beckermr commented 2 months ago

The webservices code has custom logic for the updates: https://github.com/conda-forge/conda-forge-webservices/blob/main/conda_forge_webservices/update_me.py

wolfv commented 2 months ago

My head is spinning a bit, but isn't this action run every week and also pushing a docker image? https://github.com/conda-forge/webservices-dispatch-action/blob/e19a392fd6e7e2d255c3ee76d419fd7d1a6eed93/.github/workflows/tests.yml#L90

beckermr commented 2 months ago

Yes. We do both. :)

beckermr commented 2 months ago

All of this automation is how we keep ourselves sane when running conda-forge. Otherwise, we'd have to run around updating tools and repos all the time.

wolfv commented 2 months ago

The entrypoint is also updating everything when starting?

conda update --all --yes

beckermr commented 2 months ago

Yep. You need the latest pinnings package for rerendering. At some point I had thought this was the only thing being updated, but then maybe it got switched? I don't recall.